Repository navigation
fix(sdk): restore the build — undefined event type names - #1005
Conversation
main does not compile: StreamHistoryEntry references TopUpEvent and ClawbackEvent, but events.ts imports neither. Both names exist only as deprecated aliases of StreamTopUpEvent / StreamClawbackedEvent, so use the current names directly. Effect on main before this commit: tsc --noEmit 2 errors npm run build fails (tsc -p tsconfig.build.json) npm ci fails too — prepare runs build No runtime change: the aliases are the same types.
|
@Jaydbrown — one ordering question before you spend time reviewing, since CONTRIBUTING requires CI green.
The other three PRs I opened (#1006, #1007, #1008) branch from Two ways to sequence it, whichever suits you:
Also worth flagging: all four CI runs are sitting at |
maindoes not compile.StreamHistoryEntryreferencesTopUpEventandClawbackEvent, butevents.tsimports neither. Both names exist intypes/index.tsonly asdeprecated aliases of
StreamTopUpEvent/StreamClawbackedEvent, so thisuses the current names directly rather than importing the deprecated ones.
No runtime change — the aliases are the same types, and the
kinddiscriminants are untouched.
Knock-on effect
npm cifails too, because thepreparescript runsnpm run build:So every contributor hitting a fresh clone, and every PR's CI, is red on
mainfor a reason unrelated to their change.Verification