feat(transform): SqlProgram — statement-level program AST with dirty-aware verbatim/deparse emission - #1535
Merged
Merged
Conversation
… spans, and dirty-aware verbatim/deparse emission
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
…fety and ownership-based change pruning
…2; use published StatementFacts span
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Stage 3 of the AST convergence plan (constructive-planning #1323): the statement layer that closes the gap between
PgpmScriptAst.body(opaque string) and parsed PostgreSQL ASTs — the seam every bolted-on transform lives in today — plus the first consumer:pgpm/sliceexclusion now runs over it.New in
@pgpmjs/transform(src/program.ts):The emission invariant is the point: clean statements — and every byte between statements (comments, whitespace) — are copied verbatim; only dirty statements go through the deparser. With zero dirty statements the output is byte-identical to the source (tested), so content-addressed bundle hashes are preserved by construction rather than by care.
Second commit rewires
pgpm/slice'sexcludeSubsystem/stripSubsystemSql/blankScriptSqlonto it:ExcludeResultgains aprogramfield so strip shares the analysis parse; the "parser saw N / classifier saw M, refusing to slice by index" failure mode is now impossible by construction. Public behavior/output format unchanged — slice 48 tests and pgpm/core apply suites (88, live PG) green.Uses only published deps (
@pgsql/transform18.7.0,plpgsql-parser); once upstream pgsql-parser#323 (spans onStatementFacts) is published,parseSqlProgramcan drop its own span computation.Link to Devin session: https://app.devin.ai/sessions/025fb88043964fdbb335ac5e39df2478
Requested by: @pyramation