fix(pgpm): ignore PG17+ list offsets in the AST round-trip check - #1578
Merged
Conversation
Contributor
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
pgpm packagewarns⚠️ AST round-trip diff detected!on nearly every module. Almost all of it is noise: PG17+ added positional fields thatcleanTreenever stripped —A_ArrayExpr.list_start/list_endandA_Expr.rexpr_list_start/rexpr_list_end. AnyARRAY[...]orx IN (...)shifts those byte offsets when the SQL is reformatted, so the reparsed tree never matches. Scanning constructive-db: 3775 + 78 offset-only differences across 30 modules, hiding exactly one real deparser bug (a dropped EXCLUDE constraint name — fixed in constructive-io/pgsql-parser#331).The diff check now uses a separate
cleanTreeForDiffthat also drops those four keys.cleanTreeis deliberately left alone becausehashSqlFileuses it forpgpm_migrateledger hashes — widening it there would rewrite the hash of every already-deployed change containing an array.Link to Devin session: https://app.devin.ai/sessions/5cfcc6690b574cdd96de080ee3b94b4e
Requested by: @pyramation