feat(eslint-config): shared ESLint 9 flat config, and fix this repo's lint

eslint.config.mjs

@@ -0,0 +1,21 @@
+import base from '@constructive-io/eslint-config';
+
+export default [
+  ...base,
+  { ignores: ['**/__fixtures__/output/**'] },
+  {
+    // terminal packages match/emit ANSI escape sequences on purpose
+    files: ['packages/{yanse,clean-ansi,inquirerer}/**'],
+    rules: {
+      'no-control-regex': 'off'
+    }
+  },
+  {
+    // vendored port of noble-hashes; keep it diffable against upstream
+    files: ['packages/noble-hashes/**'],
+    rules: {
+      '@typescript-eslint/no-empty-object-type': 'off',
+      '@typescript-eslint/no-unused-expressions': 'off'
+    }
+  }
+];

package.json

@@ -22,6 +22,7 @@
     "deps": "pnpm up -r -i -L"
   },
   "devDependencies": {
+    "@constructive-io/eslint-config": "workspace:*",
     "@types/jest": "^30.0.0",
     "@types/node": "^22.10.2",
     "@typescript-eslint/eslint-plugin": "^8.53.1",

packages/appstash/__tests__/appstash.test.ts

@@ -1,6 +1,7 @@
 import * as fs from 'fs';
 import * as os from 'os';
 import * as path from 'path';
+
 import { appstash, ensure, resolve } from '../src';
 
 describe('appstash', () => {

packages/appstash/__tests__/config-store.test.ts

@@ -1,6 +1,7 @@
 import * as fs from 'fs';
 import * as os from 'os';
 import * as path from 'path';
+
 import { createConfigStore } from '../src';
 
 describe('createConfigStore', () => {

packages/appstash/src/config-store.ts

@@ -1,5 +1,6 @@
 import * as fs from 'fs';
 import * as path from 'path';
+
 import { appstash, resolve } from './index';
 
 export interface ContextTargetEndpoint {

packages/appstash/src/index.ts

@@ -1,6 +1,6 @@
 import * as fs from 'fs';
-import * as path from 'path';
 import * as os from 'os';
+import * as path from 'path';
 
 /**
  * Result from appstash() containing all resolved directory paths
@@ -56,6 +56,7 @@ function getHomeDir(): string | null {
       return home;
     }
   } catch {
+    // ignore
   }
   return null;
 }
@@ -275,7 +276,6 @@ export function resolve(
   return path.join(dirs[kind], ...parts);
 }
 
-export { createConfigStore } from './config-store';
 export type {
   ClientConfig,
   ConfigStore,
@@ -286,3 +286,4 @@ export type {
   Credentials,
   GlobalSettings,
 } from './config-store';
+export { createConfigStore } from './config-store';

packages/bash-ast/test-utils/index.ts

@@ -102,11 +102,7 @@ export class FixtureTestUtils extends TestUtils {
     }
     const entries = this.getTestEntries(filters);
     for (const [relativePath, source] of entries) {
-      try {
-        await this.expectAstMatch(relativePath, source);
-      } catch (err) {
-        throw err;
-      }
+      await this.expectAstMatch(relativePath, source);
     }
   }
 }

packages/cel-proto-parser/__tests__/roundtrip.test.ts

@@ -10,8 +10,8 @@
  * manually constructed ASTs that match the @marcbachmann/cel-js format.
  */
 
-import { deparse, Expr } from '../src/deparser';
 import { convertToProtoExpr, MarcAstNode } from '../src/converter';
+import { deparse } from '../src/deparser';
 
 describe('CEL AST Converter', () => {
   describe('Value Conversion', () => {

packages/cel-proto-parser/scripts/generate.ts

@@ -1,4 +1,5 @@
 import { join, resolve } from 'path';
+
 import { CelProtoParser, CelProtoParserOptions } from '../src';
 
 const inFile: string = join(__dirname, '../__fixtures__/syntax.proto');

packages/cel-proto-parser/scripts/test-roundtrip.ts

@@ -10,12 +10,13 @@
  */
 
 import { parse } from '@marcbachmann/cel-js';
-import { deparse, Expr } from '../src/deparser';
-import { convertToProtoExpr, MarcAstNode } from '../src/converter';
 import { readFileSync } from 'fs';
-import { resolve, dirname } from 'path';
+import { dirname,resolve } from 'path';
 import { fileURLToPath } from 'url';
 
+import { convertToProtoExpr, MarcAstNode } from '../src/converter';
+import { deparse, Expr } from '../src/deparser';
+
 const __filename = fileURLToPath(import.meta.url);
 const __dirname = dirname(__filename);
 

packages/cel-proto-parser/src/ast/index.ts

@@ -1,2 +1,2 @@
-export * from './types';
 export * from './enums';
+export * from './types';

packages/cel-proto-parser/src/ast/types.ts

@@ -1,6 +1,7 @@
 import * as t from '@babel/types';
+
 import { ResolvedCelProtoParserOptions } from '../options';
-import { toCamelCase, getFieldName, createNamedImport } from '../utils';
+import { createNamedImport,getFieldName, toCamelCase } from '../utils';
 
 // Type mapping from protobuf to TypeScript
 const PROTO_TO_TS_TYPE: Record<string, string> = {
@@ -35,16 +36,16 @@ export function resolveTypeName(typeName: string): t.TSType {
   const tsType = PROTO_TO_TS_TYPE[typeName];
   if (tsType) {
     switch (tsType) {
-      case 'string':
-        return t.tsStringKeyword();
-      case 'boolean':
-        return t.tsBooleanKeyword();
-      case 'number':
-        return t.tsNumberKeyword();
-      case 'bigint':
-        return t.tsBigIntKeyword();
-      default:
-        return t.tsTypeReference(t.identifier(tsType));
+    case 'string':
+      return t.tsStringKeyword();
+    case 'boolean':
+      return t.tsBooleanKeyword();
+    case 'number':
+      return t.tsNumberKeyword();
+    case 'bigint':
+      return t.tsBigIntKeyword();
+    default:
+      return t.tsTypeReference(t.identifier(tsType));
     }
   }