chore: stage sync-versions output in the lerna version lifecycle - #111
Merged
Conversation
lerna runs the "version" lifecycle before committing, then git-adds only the
files it manages (package.json/lerna.json/changelogs). The .control, Makefile,
and sql/<mod>--<ver>.{sql,bundle.tar.gz} files that pgpm sync-versions
regenerates were left uncommitted after publish. Stage them so they land in the
same release commit/tag.
🤖 Devin AI EngineerI'll be helping with this pull request! Here's what you should know: ✅ I will automatically:
Note: I can only respond to comments from users who have write access to this repository. ⚙️ Control Options:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Same fix as constructive-platform: the root
versionlifecycle regenerates.control,Makefile, andsql/<mod>--<ver>.{sql,bundle.tar.gz}viapgpm sync-versions, but lerna only stages the files it manages (package.json / lerna.json / changelogs) when it commits. So after a release those regenerated files are published but left uncommitted/untagged in git.lerna runs the
versionlifecycle before committing and commits the index, so having the lifecycle stage its own output pulls the files into the release commit:lerna requires a clean tree before versioning, so
git add -Aonly captures whatsync-versionsproduced.Link to Devin session: https://app.devin.ai/sessions/a36069d7d4bc40328567bb0caa9ba250
Requested by: @pyramation