Skip to content

ci: drop the download proxy from the base-arm64 job - #7682

Merged
viceice merged 1 commit into
mainfrom
viceice/ci/drop-arm64-download-proxy
Oct 8, 2026
Merged

viceice merged 1 commit into
mainfrom
viceice/ci/drop-arm64-download-proxy

Conversation

@viceice

@viceice viceice commented Oct 8, 2026 •

Copy link
Copy Markdown
Member

Changes

Drops the download proxy from the base-arm64 job. Its test-base bake downloads no tools, so the proxy only ever served its own startup check (1 request, 0 hits in #7670's last run). distro and lang keep it.

Context

Please select one of the following:

  • This closes an existing Issue, Closes: #
  • This doesn't close an Issue, but I accept the risk that this PR may be closed if maintainers disagree with its opening or implementation

Follow-up to #7670.

AI assistance disclosure

Did you use AI tools to create any part of this pull request?

Please select one option and, if yes, briefly describe how AI was used (e.g., code, tests, docs) and which tool(s) you used.

  • No — I did not use AI for this contribution.
  • Yes — minimal assistance (e.g., IDE autocomplete, small code completions, grammar fixes).
  • Yes — substantive assistance (AI-generated non‑trivial portions of code, tests, or documentation).
  • Yes — other (please describe):

Written by Claude Opus 5.5 in Claude Code.

Use of AI in replying to PR comments

Who answers review comments:

  • @viceice will read and reply directly. Name the account.
  • An agent will draft replies and @username will read them before they are posted. Name the account.
  • An agent will draft replies and reply autonomously. This is heavily discouraged, and we prefer that there are humans in the loop
  • Nobody has explicitly committed to replying.

Documentation (please check one with an [x])

  • I have updated the documentation, or
  • No documentation update is required

How I've tested my work (please select one)

I have verified these changes via:

  • Code inspection only, or
  • Newly added/modified tests

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • The ARM64 base build no longer downloads the proxy or reports proxy errors and cache statistics. Initialization and base tests remain unchanged.

Co-Authored-By: Claude Opus 5.5 <michael.kriese+claude-code@mend.io>
@viceice
viceice enabled auto-merge October 8, 2026 19:36
@qodo-code-review

Copy link
Copy Markdown

PR Summary by Qodo

Remove unused download proxy from base-arm64 CI job

⚙️ Configuration changes 🕐 Less than 10 minutes

Grey Divider

AI Description

• Remove proxy startup from base-arm64, whose test-base bake downloads no tools.
• Remove proxy-specific error and cache-stat steps from that job; distro and lang retain theirs.
Diagram

graph TD
  ARM["base-arm64 job"] --> BASE["test-base bake"]
  OTHER["distro and lang"] --> PROXY["Download proxy"] --> TESTS["Tool tests"] --> DIAG["Proxy diagnostics"]
Loading
High-Level Assessment

Remove the proxy only from the job that does not use it. Keeping it for consistency would preserve startup overhead and a proxy-specific failure point without benefiting test-base.

Files changed (1) +0 / -11

Other (1) +0 / -11
build.ymlDrop unused proxy steps from base-arm64 +0/-11

Drop unused proxy steps from base-arm64

• Removes download-proxy startup, failure diagnostics, and cache statistics from 'base-arm64'. Its 'test-base' bake remains unchanged, as do the proxy steps in 'distro' and 'lang'.

.github/workflows/build.yml

@coderabbitai

coderabbitai Bot commented Oct 8, 2026 •

Copy link
Copy Markdown

Review in Change Stack →

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Repository: containerbase/coderabbit/.coderabbit.yaml
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 0170fdcc-c45a-446d-811b-4c4f1fdd8224
📥 Commits

Reviewing files that changed from the base of the PR and between 263539b and 2dc12e6.

📒 Files selected for processing (1)
  • .github/workflows/build.yml
💤 Files with no reviewable changes (1)
  • .github/workflows/build.yml

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.


📝 Walkthrough

Walkthrough

The base-arm64 job no longer downloads the proxy or runs proxy error and cache-stat reporting steps. Its initialization and test-base step remain.

Changes

ARM64 build workflow

Layer / File(s) Summary
Remove proxy workflow steps
.github/workflows/build.yml
The base-arm64 job skips proxy download and removes proxy error and cache-stat reporting steps.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 2dc12

The base-arm64 job can run without the removed download proxy; the change is ready for normal checks and merge.

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: removing the download proxy from the base-arm64 CI job.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@qodo-code-review

Copy link
Copy Markdown

Code Review by Qodo

🐞 Bugs (0) 📘 Rule violations (0) 📎 Requirement gaps (0)

Grey Divider

Great, no issues found!

Qodo reviewed your code and found no material issues that require review

Grey Divider

Tip of the day
💡 Did you know, you can keep summaries lean with Findings visible per group, which tucks the rest behind a View link

More tips ↗ | Customize Qodo ↗ | Qodo docs ↗

Grey Divider

Qodo Logo

@viceice
viceice added this pull request to the merge queue Oct 8, 2026
Merged via the queue into main with commit db34906 Oct 8, 2026
61 checks passed
@viceice
viceice deleted the viceice/ci/drop-arm64-download-proxy branch October 8, 2026 20:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant