Remove nearest neighbor hack - #173
Open
parshadkp wants to merge 18 commits into
Open
Conversation
In anticipation of PR cositools#165
|
Now that #165 is merged, we should also tackle this. |
parshadkp
marked this pull request as ready for review
August 11, 2026 16:47
…add NN strip hits if missing
ckierans
reviewed
Aug 18, 2026
ckierans
left a comment
ckierans
left a comment
Collaborator
There was a problem hiding this comment.
Looks good, Parshad. I'm fine with you removing the CountRate function, since it seems like something that doesn't quite belong here as a diagnostic, but I just wanted to check your motivation for removing it.
| ASICChannelsSet.insert(ID); | ||
| ASICChannelsSet.insert(ID + 1); | ||
| } | ||
| ASICChannelsSet.insert(ID); |
Author
|
Hi @ckierans, I think this looks good to merge now but let me know if you have any other comments. |
|
But this also has the code from PR190 in it now? |
…ad_fork into NN_strip_fix
…zer_parshad_fork into NN_strip_fix" This reverts commit 798a408.
Author
Sorry, I must have accidentally pushed my local changes when I was testing. Should be fixed now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This will remove the nearest neighbor hack that was introduced a while ago to calculate the correct dead time in the strip trigger module. The change is simple but I will make this "ready to review" once PR #165 is merged. This will also close Issue #93.