Repository navigation
chore(deps): update express to 5.2.1 - #252
deniswsrosa wants to merge 1 commit into
Conversation
There was a problem hiding this comment.
Code Review
This pull request upgrades the express dependency from version 4.x to 5.x, updating its corresponding sub-dependencies in package-lock.json. Additionally, in src/app.js, the wildcard route handler has been changed from app.get('*', ...) to a catch-all middleware app.use(...) to handle 404 errors for all HTTP methods instead of just GET requests. There are no review comments, and I have no feedback to provide.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
Consolidates the open Dependabot updates into this PR: - express ^4.22.2 -> ^5.2.1 (supersedes #240, #256; overlaps #252) - transitive refresh via npm update: qs 6.16.0, tar 7.5.22, brace-expansion 1.1.21 / 2.1.7 / 5.0.12, body-parser 2.3.0 via express 5 (supersedes #253, #254, #255) - Express 5 / path-to-regexp v8: catch-all route '*' -> '/{*splat}' - add a test covering the catch-all 404 route Lockfile kept at v2 and regenerated with npm 10.8.2 on Node 20.20.2. Babel 8 (#239) is still out: it needs Node ^22.18 || >=24.11 and the repo stays on Node 20. Hermes task: t_5e4f3c90 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@dex-the-ai is this superseded by another pr? |
|
@ejscribner Yes, #257 supersedes this one. #257 is "chore(deps): consolidate dependency updates (express 5, jest, prettier, supertest, transitive)" and it was merged into This PR has nothing left that
If you rebased this branch now, you'd get lockfile conflicts and no functional change. I'd suggest closing it as superseded by #257. I've left it open because it's @deniswsrosa's PR. |
Summary
expressfrom^4.22.2to^5.2.1and regeneratespackage-lock.jsonwith the existing npm lockfile v2 format.app.get('*', ...)->app.use(...)).^22.18.0 || >=24.11.0, while this repository's CI and Dockerfile target Node 20.Updated dependencies
Validation
Commands run locally:
npm install --lockfile-version=2; lockfile remains version 2.npm ls --depth=0showsexpress@5.2.1; Babel packages remain 7.29.7 due Node 20 constraint.npm run buildcompiled 10 files with Babel.npm run testGA: 19/19 test suites passed against local Couchbasetravel-sample.npm test: 19/19 test suites passed viaconfig/test.env.node:20rannpm ciandnpm run buildsuccessfully./swagger-ui/with Swagger UI title and OpenAPI endpoint listing.Risk notes
dist,node_modules, environment files, Couchbase logs, or evidence artifacts are committed.Rollback
Revert this PR to restore
expressto^4.22.2, the previous lockfile graph, and the prior catch-all route declaration.