Fix checkStyle final local var and PDM SingularField warning in Document class#497
Closed
pasin wants to merge 1 commit into
Closed
Fix checkStyle final local var and PDM SingularField warning in Document class#497pasin wants to merge 1 commit into
pasin wants to merge 1 commit into
Conversation
|
This is a release branch and commits are restricted. Please confirm this PR is one of the following:
|
* As var is unavailable for source Java 8 source level, use FLDict type explicitly. * Made local data variable in Document’s setContent() final per check style warning. * Suppress the PMD SingularField warning on extraBackingStore, which is written but never read. It cannot be made a local variable as PMD suggests because it is for keeping the native Fleece backing store from being GC’d while the Document is alive.
pasin
force-pushed
the
fix-style-pdm-check
branch
from
3a820f5 to
3213df1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix using var and PDM SingularField warning in Document class
As var is unavailable for source Java 8 source level, use FLDict type explicitly.
Made local data variable in Document’s setContent() final per check style warning.
Suppress the PMD SingularField warning on extraBackingStore, which is written but never read. It cannot be made a local variable as PMD suggests because it is for keeping the native Fleece backing store from being GC’d while the Document is alive.