Repository navigation
fix race - #41
Merged
Merged
fix race#41
Conversation
Change-Id: I6f8e5cff27f333f3f0e0c9579f782b08bd29d5a4 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Export path read span.TagMap/SystemTagMap without holding s.lock while writers (SetTags) mutate under lock, causing "concurrent map iteration and map write". Read a single locked snapshot per span via GetTagMap and new GetSystemTagMap, threaded through parseInputOutput/parseTag. Also add race regression tests and fix outdated test call sites. Change-Id: I9509e82ca5df8eb15cde5dcc871403fe7ac539a5 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Change-Id: I59f42eb43cf5ee9a3d645bd09202199ed4b3d7da
cuichen01
approved these changes
Jul 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.