test-server $cql returns 400 on cql-to-elm translation errors - #379
Merged
Merged
Conversation
…elm translation has an error
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #379 +/- ##
=======================================
Coverage 89.22% 89.22%
=======================================
Files 60 60
Lines 5116 5116
Branches 1468 1468
=======================================
Hits 4565 4565
Misses 316 316
Partials 235 235 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a check for cql-to-elm translation errors in the test-server $cql operation, and if any occur, the return is now HTTP 400 with the translation error. This is implemented by adding a new
TranslationErrorclass. I added one test case with Codex but I'm still thinking about how best to add more.This is targeted at cql-tests that have
invalid="true", for instance test "EquivTupleJohnJohnFalse". cql-tests-runner results from before and after this change:Before:
After:
Pull requests into cql-execution require the following.
Submitter and reviewer should ✔ when done.
For items that are not-applicable, mark "N/A" and ✔.
Submitter:
npm run checkto run tests, lint, and prettier)Reviewer:
Name: