fix(store): fuse observed streams after EOF - #46
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Fuse observed GET, listing, and deletion streams so polling after EOF returns
None. This preventsfutures_util::stream::unfoldpanics whenGetResult::bytescollects a zero-chunk body. Record exactly one terminal observation and release active accounting once.Verification
Unfold must not be polled after it returned Poll::Ready(None).No durability acknowledgment, authority, routing, wire format, or lockfile changes. BeyondDB pins this exact commit in PR 15. Its original follower process-kill test passes twice locally with its assertions unchanged, and the full signed SDK CI passes: native 49/49, peers 88/88, processes 8/8. Separate local coordinator-churn lease-fencing failures remain unresolved. All ten Cellule CI checks pass. Benchmark records remain local and are excluded from Git.