Resolve Python receiver calls and audit impact coverage - #343
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Python service callee queries could report zero despite attribute-chain calls, while impact summaries counted only the capped presentation results. This change preserves source invocations, resolves supported nominal receivers, and independently audits direct impact.
--relation/ MCPrelationsfilters. Count and group direct/transitive dependents independently of the presentation cap, and fail a complete audit if selected direct dependents were omitted. Every known direct contact is accounted for as a dependent, outgoing context or exclusion; outgoing references are not claimed affected code.Compatibility: optional graph
callSitesand querycallSummary/impactSummaryfields; disposable AST cache version 14. Rebuild Python graphs to obtain inventories. Historical graphs remain readable and immutable. Command, contract and migration documentation is included.Public-repository qualification used a read-only pinned Dify checkout. A source-first seeded sample captured 2,550/2,550 source calls across 10 production services: 698 sites had all-exact target evidence and 1,537 had inferred edge evidence. These are capture measurements, not a claim of exact runtime dispatch. All five widely used symbol audits accounted for their complete published direct adjacency. The graph retained its partial-source warning for 15 quarantined edges. Reproduction steps and reviewed source links are in
docs/implementation/python-call-impact-qualification.md.The fixture graph adds 17 explicitly inferred receiver nodes. Five density/exact-isolation baselines are adjusted for that addition; the absolute exact-edge, exact cross-file-edge and typed endpoint floors, relationship-specific gates and semantic assertions are retained. Exact edges increase from 956 to 962 and exact cross-file edges remain 56.
Validation:
cargo fmt --all -- --check--lib --bins --locked -- -D warnings) and workspace library/binary tests./scripts/qualify_code_graph_v1.sh --fixtures-onlyJavaScript, packaging and other platform matrices are left to CI; no JavaScript sources changed. Rust builds and qualification artifacts were kept in this checkout's external target directory.