Repository navigation
fix/issue 759 guard rpcstarted against a throwing met - #764
Merged
s2x merged 4 commits intoOct 24, 2026
Merged
Conversation
…-rpcstarted-against-a-throwing-met
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #759
Follow-up to #274 (already merged): the
rpcCompleted()half of the RPC metric is guarded throughcompleteRpc(), but therpcStarted()half was not. That emission sits before the call, so a metrics backend that throws from it aborted a call that never happened and replaced the transport exception the caller has to see.GrpcClient::startRpc()now guards it the same waycompleteRpc()does.