Repository navigation
fix: fall through to app on allowlist mismatch when no file exists - #1120
Open
rootsiemen wants to merge 1 commit into
Open
rootsiemen wants to merge 1 commit into
rootsiemen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1118
The allowlist prefilter answered a bare 404 for any disallowed extension, even when no such file exists, so app routes like /sitemap.xml, /feed.json or /api/export.csv never reached the Symfony app. The prefilter now only answers 404 when the path resolves to an existing file; otherwise the request falls through to the application (fail-open, DEC-013). An existing disallowed file still gets 404, covered by testAllowedExtensionsWhitelistBlocking.
Tests: updated testAllowlistFastPathRejectsDisallowedExtensionBeforeFilesystemProbe to the new fall-through behavior (renamed testAllowlistMismatchFallsThroughWhenNoFileExists) and added testAllowlistMismatchDoesNotShadowAppRoutes covering the issue repro paths.