Repository navigation
fix: reject non-scalar file entry fields before UploadedFile construction - #1121
Open
rootsiemen wants to merge 1 commit into
Open
rootsiemen wants to merge 1 commit into
rootsiemen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1111
Nested multipart fields (f[name][x], f[tmp_name][x], ...) make a file entry's leaves arrays instead of scalars. processFileEntry() only checked that the keys exist, so the array reached UploadedFile::__construct() and raised an uncaught TypeError (500) on client input. FileUploadValidator::assertFieldTypes() now checks the leaf types first (name/tmp_name/type strings, size/error ints) and throws FileUploadValidationException, which the handler classifies as a 400 client error.
Tests: testNestedFileFieldLeavesThrowFileUploadValidationException (the issue's nested-field shape) and testNonIntegerFileErrorFieldThrowsFileUploadValidationException (array in error, the smaller fuzz input from the issue).