Repository navigation
fix: validate max_requests reload configuration ranges - #1129
Open
rootsiemen wants to merge 1 commit into
Open
rootsiemen wants to merge 1 commit into
rootsiemen wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1123
The max_requests reload configuration accepted any integer for requests and dispersion, so some combinations built an invalid random range: requests 100 with dispersion -20 derives a minimum of 120, and Randomizer::getInt(120, 100) throws a bare ValueError at worker start.
Changes:
Verification: the edited ConfigurationTreeBuilder.php was diffed against the upstream blob to confirm the only change is the max_requests node; the two docs files were diffed the same way. No PHP runtime is available in this environment, so phpunit could not be run locally — please rely on CI for the test run.