Skip to content

Add safe deletion for SD card transaction and descriptor files - #391

Open
nonoplzno wants to merge 1 commit into
cryptoadvance:masterfrom
nonoplzno:atanatus/issue-359
Open

nonoplzno wants to merge 1 commit into
cryptoadvance:masterfrom
nonoplzno:atanatus/issue-359

Conversation

@nonoplzno

Copy link
Copy Markdown

Summary

Adds safe deletion of transaction data and wallet descriptor files directly from the Open SD card file menu.

Implementation

  • Adds a dedicated Delete a file menu action.
  • Lists only the same supported .psbt, .txt, and .json files already accepted by the SD host.
  • Requires explicit confirmation before deletion.
  • Synchronizes the filesystem after deletion.
  • Reports deletion failures through HostError.
  • Leaves cancellation and normal file selection unchanged.

Verification

  • Python syntax validation passed.
  • Behavioral test passed for:
    • confirmed deletion;
    • cancelled deletion;
    • normal file selection;
    • unsupported files remaining untouched.
  • git diff --check passed.

close #359

@netlify

netlify Bot commented Aug 28, 2026

Copy link
Copy Markdown

Deploy Preview for specter-diy-docs ready!

Name Link
🔨 Latest commit 3147eba
🔍 Latest deploy log https://app.netlify.com/projects/specter-diy-docs/deploys/6a91c2445335d70008ae2af3
😎 Deploy Preview https://deploy-preview-391--specter-diy-docs.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify project configuration.

@nonoplzno

Copy link
Copy Markdown
Author

@stepansnigirev @k9ert This implementation is ready for maintainer review.

Validation completed:

  • Python syntax: PASS
  • confirmed deletion behavior: PASS
  • cancelled deletion preserves the file: PASS
  • normal file selection remains unchanged: PASS
  • unsupported files remain untouched: PASS
  • git diff check: PASS

The deletion action is restricted to files already accepted by the SD host and requires explicit confirmation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SD Card Transaktion Data and Wallet Descriptors cannot be deleted at the Specter DIY

1 participant