fix(ci): use DOCKERHUB_USERNAME secret instead of hardcoded registry namespace - #152
Open
EliShteinman wants to merge 2 commits into
Open
EliShteinman wants to merge 2 commits into
EliShteinman wants to merge 2 commits into
Conversation
…namespace Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
There was a problem hiding this comment.
Pull request overview
This PR updates the DockerHub build/push GitHub Actions workflow to make the Docker image namespace configurable via a secret, avoiding hardcoded crystaldba/... references that break builds on forks.
Changes:
- Replace hardcoded
crystaldba/postgres-mcpimage name with${{ secrets.DOCKERHUB_USERNAME }}/postgres-mcp - Update registry build cache
refvalues to use${{ secrets.DOCKERHUB_USERNAME }}as well
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
jssmith
reviewed
Aug 19, 2026
jssmith
left a comment
Contributor
There was a problem hiding this comment.
Review — concise
Verdict: Approve. Simple, correct CI fix.
Summary
Replaces hardcoded crystaldba/postgres-mcp Docker Hub namespace with ${{ secrets.DOCKERHUB_USERNAME }}/postgres-mcp in the Docker build workflow. Applied to image tags and build cache references.
Correctness
- All four references updated consistently:
images,cache-from,cache-to, and the metadata action. - Using a secret for the namespace is the right approach — avoids hardcoding org names in CI config.
- No logic changes, just variable substitution.
Minor (non-blocking)
- Verify
DOCKERHUB_USERNAMEsecret is set in the repo settings before merging, otherwise the build will push to/postgres-mcp(empty namespace).
This review was created by an AI agent (OpenHands) on behalf of @jssmith.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
crystaldba/postgres-mcphardcoded as the image name and cache registry referencescrystaldba/postgres-mcpcrystaldbareferences with${{ secrets.DOCKERHUB_USERNAME }}so each fork can configure its own DockerHub namespace