Repository navigation
Fix compilation bugs - #15
Merged
Merged
Conversation
mwiering
reviewed
Aug 26, 2026
mwiering
left a comment
mwiering
left a comment
Contributor
There was a problem hiding this comment.
All looks good but automatic build is failing for linux - fetch of the pgplot code is not working. There were some Node.js deprecation warnings so I've updated the actions. Maybe merge in master and see how it goes.
mwiering
approved these changes
Sep 14, 2026
Contributor
|
Needed a rebase from master to build successfully, so did that in a forced merge. |
Author
|
Thanks @mwiering! Sorry for the pain on this one |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi there,
I hit a couple of compilation/build bugs with
-DLARGEN=ONandCMake< 3.24 - this should fix both:pgplot/CMakeLists.txt: DOWNLOAD_EXTRACT_TIMESTAMP is only a recognized
ExternalProject_Add keyword on CMake >= 3.24. On older CMake it was
getting absorbed into PATCH_COMMAND, corrupting the patch invocation
(
patch: Can't open patch file TRUE). Now only passed when supported.CMakeLists.txt: LARGEN's enlarged COMMON blocks overflow the default
small memory model's 32-bit relocations at link time
(
relocation truncated to fit). Add -mcmodel=medium for C/Fortranwhen LARGEN is enabled.