Skip to content

Update use_connection_pooling (False) to address session overwriting - #94

Closed
rollerbrick wants to merge 2 commits into
customerio:mainfrom
rollerbrick:fix_connection_pooling
Closed

rollerbrick wants to merge 2 commits into
customerio:mainfrom
rollerbrick:fix_connection_pooling

Conversation

@rollerbrick

Copy link
Copy Markdown

When using CustomerIO with use_connection_pooling set to False the following error is occasionally produced. This PR changes use_connection_pooling (False) so it doesn't use self._current_session.

Traceback (most recent call last):
  ...
  File "...customerio/track.py", line 72, in identify
    self.send_request('PUT', url, kwargs)
  File "...customerio/client_base.py", line 55, in send_request
    self._close()
  File "...customerio/client_base.py", line 112, in _close
    self._current_session.close()
AttributeError: 'NoneType' object has no attribute 'close'

@hownowstephen

Copy link
Copy Markdown
Contributor

Superseded by #118 (merged), which fixed no-pooling session isolation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants