Update Pull Request Template - #100
Open
cwisniew wants to merge 236 commits into
Open
Conversation
ShapeDrawable and AbstractDrawing. - On FALSE it returns the Zone.Layer.name() instead of Zone.Layer.value()
This reverts commit 92f8e77.
added extended delimiter parameters to shape.properties to resolve nested string property list and string list issues.
Resolves RPTools#5917 Integrated usage of createAssetDetectType, removed file header byte checks
Added cache. Moved in-house helpers to a separate class. Added helpers for mark-down, simple maths, and string comparison.
…lpers # Conflicts: # src/main/java/net/rptools/maptool/util/HandlebarsUtil.java
…ions' into feature/5906-new-json-html-functions
otherwise it breaks drawing user interactions. Updated ShapeFunctions method drawShape to assign a new ID to the copied ShapeDrawable.
Fix for localised string being unhelpful in shape.getProperties()
Add VBL Pen tool for freehand topology drawing
…enderer Fix GridRenderer hygiene
…-display Fix ChatTypingPanel and ChatActionLabel notifications not displaying Take 2
…ed-module-on-windows Open com.sun.java.swing.plaf.windows again
…ow-details-view-and-other-fixes Tables window details view and other fixes
This makes campaign writing more robust as it can simply ask for the list of relevant assets rather than first trying to figure out the types of all the states and bars.
`AbstractImageTokenOverlay` is the base for `ImageTokenOverlay`, `CornerImageTokenOverlay`, and `FlowImageTokenOverlay`. In places where a type check is needed to look for an image-based overlay, `AbstractImageTokenOverlay` is now checked instead of `ImageTokenOverlay`. The new base class also provides an implementation of `#getAssetId()` and `#getAssets()` so child classes don't have to worry about it.
`Campaign#getAllAssetIds()` new leverages `CampaignProperties#getAllImageAssets()` rather than duplicating the same logic for lookup tables, bars, and states. `CampaignProperties#getAllImageAssets()` in turn now uses `AbstractTokenOverlay#getAssets()` rather than enumerating the possible types that could have assets.
- `getBarImage()` macro function implementation and `TokenBarController` to use the new list-based `AbstractTokenOverlay#getAssets()`
- `TokenStatesController` uses switch for exhaustiveness over all state types
- `getInfo("campaign")` shows the grid size for shape-based flow states and image-based flow states
- `getStateImage()` macro function checks for `AbstractImageTokenOverlay` rather than `ImageTokenOverlay``
…setIds() In `MultipleImageBarTokenOverlay`, replace the array-based accessor and mutator with `List`-based ones.
Each implementation now sets all relevant properties (a bunch of these were missed after splitting out `XTokenOverlay` as a base class). Where possible, the logic is shared according to base class rather than replicating it per concrete class.
…nt-and-soft-fog Allow local movement to be visible in soft fog
…s-for-html-frames-and-dialogs Use assets for custom html frame and dialog icons
…g-corner-image-asset-ids Fix for missing state image assets in campaign files
Add more output info to build log and upload test results to artifacts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Requirements for Contributing a Bug Fix or Enhancement
and possibly closure of the pull request if it is not provided after this request.
Identify the Bug or Feature request
Description of the Change
Possible Drawbacks
Documentation Notes
Release Notes