Repository navigation
fix(ci): stop the nightly 100K Rust recall gate from timing out - #1305
Merged
Merged
Conversation
Every run of the nightly "Scheduled Rust 100K recall (Fast/Balanced/ Accurate/Perfect)" job has been cancelled at its 60-minute timeout since it was added on 2026-06-24 (8 consecutive failures, runs #307-#351) — the gate has never once produced a pass/fail signal. Two compounding issues: (1) scale_recall_100k.rs built a fresh 100K-vector HNSW index from scratch in each of 4 separate #[test] fns instead of sharing the fixture, a 4x cost multiplier; (2) the CI step ran cargo test without --release, and debug-mode HNSW insert/search at 100K vectors is an order of magnitude slower. Merges the four tests into one that builds the fixture once and asserts all four per-mode thresholds, and adds --release to the CI invocation. Verified locally (release, --ignored): 14.4s total, all four thresholds hold at the same values as before (Fast 0.945/Balanced 0.973/Accurate 0.997/Perfect 1.000).
Up to standards ✅🟢 Issues
|
12 of 13 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Cherry-picks #1302's diff onto a Git-Flow-compliant branch/identity — the original PR's own body flagged that it would fail the branch-prefix and AI-attribution governance gates (same situation as #1289 → #1295).
scale_recall_100k.rsbuilt a fresh 100K-vector HNSW index from scratch in each of 4 separate#[test]fns instead of sharing the fixture (4x cost multiplier), and (2) the CI step rancargo testwithout--release— debug-mode HNSW insert/search at 100K vectors is an order of magnitude slower.scale_100k_recall_all_qualities) that builds the fixture once and asserts all four per-mode thresholds, and adds--releaseto the CI invocation.Test plan
--ignored): 14.4s total (previously never completed within the 60-minute CI budget). All four thresholds hold: Fast 0.9450 (≥0.90), Balanced 0.9730 (≥0.95), Accurate 0.9970 (≥0.98), Perfect 1.0000 (=1.00)cargo fmt -p velesdb-core --check— cleancargo clippy -p velesdb-core --test scale_recall_100k --release --features persistence -- -D warnings -D clippy::pedantic— cleanCloses #1302 (superseded — see that PR for the original CI audit that found this).