Repository navigation
fix(core): take graph-anchored NEAR candidates at the configured [search] quality (#2430) - #2473
cyberlife-coder wants to merge 1 commit into
Conversation
…rch] quality (#2430) search_anchors_bitmap pinned SearchQuality::default() (Balanced) and so ignored [search] default_mode / ef_search. Route it through runtime_search_quality(), as the hybrid and graph-embedding sites already do. Default config still resolves to Balanced, so results are unchanged unless [search] is customised.
Up to standards ✅🟢 Issues
|
| Metric | Results |
|---|---|
| Complexity | 0 |
NEW Get contextual insights on your PRs based on Codacy's metrics, along with PR and Jira context, without leaving GitHub. Enable AI reviewer
TIP This summary will be updated as you push new changes.
|
Thank you for your contribution to VelesDB! Before this PR can be merged, please sign the Contributor License Agreement by posting the following comment:
This grants the project a license to use your contribution under the VelesDB Core License 1.0 and future licensing terms. I have read the CLA Document and I hereby sign the CLA You can retrigger this bot by commenting recheck in this Pull Request. Posted by the CLA Assistant Lite bot. |
|
Two red checks on 0312cc5, neither a code failure:
The change itself (one line in Generated by Claude Code |
Summary
Part of #2430 (2026-10-25 audit of its table against
develop).search_anchors_bitmap(collection/search/query/graph_prefilter.rs) passedSearchQuality::default()(Balanced), so a graph-anchoredNEARover a large anchor set ignored[search]default_mode/ef_search. It now usesself.runtime_search_quality(), asbatch.rs,text.rs,text_fusion.rsandgraph_api.rsalready do.Balanced: results change only for users who set a non-default[search](same behaviour note as core: a search that sets only rerank runs at Balanced, not the configured [search] default #2399).Status of the #2430 table (against
developat e75c6bd)hybrid_search(text.rs)text_fusion.rs)search_by_embeddingon graph collections (graph_api.rs)NEARbitmap pathNEARvia secondary-index bitmap (vector.rs,search_with_optional_bitmap)ef_search = candidates_k.max(k * 10), so following[search]there is a design decision, not a one-line routing fixVerification
cargo check -p velesdb-core --features persistence,cargo fmt --all -- --check: clean.cargo test -p velesdb-core --features persistence --lib anchor -- --test-threads=1: 26 passed.Not done
ANCHORED_EXACT_SCORE_MAX(10 000 anchors), andsearch_near_with_anchor_idsispub(crate), so a test intests/search_config_defaults.rsneeds a 10k+ node graph driven through VelesQLMATCH. Left for the maintainer to decide.scripts/local-ci.shand pedantic clippy were not run.claude/*, whichpr-governancerejects; it needs renaming to a permitted prefix (e.g.fix/) before this can merge.Generated by Claude Code