skaffold-build: build via deployments build_it.yml, push descriptor to deployments#7
Open
johnworth wants to merge 1 commit into
Open
skaffold-build: build via deployments build_it.yml, push descriptor to deployments#7johnworth wants to merge 1 commit into
johnworth wants to merge 1 commit into
Conversation
…o deployments Instead of building the image in-workflow and pushing a descriptor plus skaffold/k8s copies into cyverse-de/de-releases, the workflow now checks out the deployments repo and runs its build_it.yml playbook for the service. The playbook builds and pushes the image and rewrites the canonical descriptor at ansible/roles/services/<svc>/files/<svc>.json, which the workflow then commits and pushes directly to the deployments main branch. - New inputs service-name, deployments-repo, deployments-branch; the service role is verified to exist before running so an unknown --tag can't silently build nothing. - Drops the GitHub release, de-releases checkout, and jq/yq/kube-tools; adds skaffold + ansible install. build-prerelease is kept but deprecated/ignored. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Rewrites the reusable
skaffold-build.ymlworkflow to fit the newdeploymentsrepo layout (itsunificationbranch). Instead of building the image in-workflow and pushing a descriptor plus skaffold/k8s copies intocyverse-de/de-releases, the workflow now:cyverse-de/deployments@mainas siblings,build_it.ymlplaybook for the service, which builds + pushes the image and rewrites the canonical descriptor atansible/roles/services/<svc>/files/<svc>.json,mainbranch.The build itself runs through the deployments repo's custom buildx builder, preserving the
<image>:cachemode=max registry layer cache (so Clojure/Maven dependency downloads are reused instead of re-fetched from upstream).Changes
service-name,deployments-repo,deployments-branch.--tagscan't silently build nothing.de-releasescheckout, and the jq/yq/kube-tools installs; adds skaffold + ansible installs.build-prereleaseis kept but deprecated/ignored (no GitHub release is created anymore), so existing callers don't break.docker-build.ymlandgo-build.ymlare intentionally unchanged.Merge ordering
unificationbranch (custom builder + descriptor paths) must merge to deploymentsmainbefore this merges tomain— otherwise the playbook, custom builder, andfiles/<svc>.jsontargets won't exist on deploymentsmain.Notes
releases-repo-push-tokenmust have push access to deploymentsmain.--file-outputproduces the exact canonical descriptor format; all deployments skaffold configs parse; the workflow passesactionlint.🤖 Generated with Claude Code