Repository navigation
d2sequence: account for self and sibling message height in note placement - #2940
Open
AdamMagued wants to merge 1 commit into
Open
AdamMagued wants to merge 1 commit into
AdamMagued wants to merge 1 commit into
Conversation
…ment When positioning notes in sequence diagrams, vertical offsets only accounted for self-messages where source matched destination directly. Messages between spans of the same actor or descendant/sibling relations also consume extra vertical space for loop routing. Because note placement ignored that space, notes appearing after sibling messages were placed too high, causing subsequent groups to overlap preceding groups. Extract an isSelfOrSibling helper shared by routeMessages and placeNotes, and account for the full height of self and sibling messages during note positioning. Add tests covering group overlap prevention with notes.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2939
Problem
When notes are positioned in sequence diagrams, vertical offsets only accounted for self-messages where source matched destination directly (msg.Src == msg.Dst). Messages between descendant spans or sibling spans sharing the same actor root are routed as multi-point self-loops, which occupy extra vertical space. Because note placement overlooked these messages, notes following sibling messages were positioned prematurely along the Y axis. Consequently, subsequent groups containing or starting with such notes computed overlapping bounding boxes.
Solution