Skip to content

docs(decisions): accept the ADRs added by the second issue batch #911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
samtrion merged 1 commit into from
Sep 29, 2026
Merged

docs(decisions): accept the ADRs added by the second issue batch #911

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions decisions/2026-09-28-audit-write-fail-open.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,9 +7,9 @@ applyTo:

created: 2026-09-28

lastModified: 2026-09-28
lastModified: 2026-09-29

state: proposed
state: accepted

instructions: |
AuditRequestInterceptor MUST wrap only the handler call in try/catch; the audit record MUST reflect the handler outcome only (Success when it completed, Failure with the handler's exception message when it threw).
Expand Down
4 changes: 2 additions & 2 deletions decisions/2026-09-28-entityframework-and-cosmosdb-outbox-lease-reclaim.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,9 +9,9 @@ applyTo:

created: 2026-09-28

lastModified: 2026-09-28
lastModified: 2026-09-29

state: proposed
state: accepted

instructions: |
MUST reclaim Processing outbox messages whose UpdatedAt is at or before now minus ProcessingLeaseTimeout in the Entity Framework Core and Cosmos DB GetPendingAsync, as part of the same claim predicate as Pending messages; MUST NOT add a lease column.
Expand Down
4 changes: 2 additions & 2 deletions decisions/2026-09-28-idempotency-refresh-expired-keys-on-reserve.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ applyTo:

created: 2026-09-28

lastModified: 2026-09-28
lastModified: 2026-09-29

state: proposed
state: accepted

instructions: |
IdempotencyStore MUST reserve and store keys through IIdempotencyKeyRepository.TryReserveAsync(key, createdAt, validFrom), never through ExistsAsync followed by StoreAsync.
Expand Down
4 changes: 2 additions & 2 deletions decisions/2026-09-28-opentelemetry-telemetry-conventions.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,9 @@ applyTo:

created: 2026-09-28

lastModified: 2026-09-28
lastModified: 2026-09-29

state: proposed
state: accepted

instructions: |
MUST leave the activity status Unset when a Pulse operation succeeds or a stream consumer stops early; MUST set Error with the exception message only on failure.
Expand Down
4 changes: 2 additions & 2 deletions decisions/2026-09-28-rabbitmq-transport-publisher-confirms.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,9 +8,9 @@ applyTo:

created: 2026-09-28

lastModified: 2026-09-28
lastModified: 2026-09-29

state: proposed
state: accepted

instructions: |
RabbitMqConnectionAdapter MUST create every channel with new CreateChannelOptions(publisherConfirmationsEnabled: true, publisherConfirmationTrackingEnabled: true), built per call.
Expand Down
2 changes: 1 addition & 1 deletion decisions/2026-09-29-outbox-handler-runs-before-event-dispatcher.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,7 @@ created: 2026-09-29

lastModified: 2026-09-29

state: proposed
state: accepted

instructions: |
MUST invoke OutboxEventHandler<TEvent> in PulseMediator sequentially and before the configured IEventDispatcher, inside the event interceptor chain, and MUST pass only the remaining handlers to the dispatcher.
Expand Down
2 changes: 1 addition & 1 deletion decisions/2026-09-29-process-local-cache-invalidation.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ created: 2026-09-29

lastModified: 2026-09-29

state: proposed
state: accepted

instructions: |
The cache key registry used by AddCacheInvalidation MUST stay process-local and in-memory; IInvalidatingCommand evicts only the keys this process cached since it started.
Expand Down
Loading