Skip to content

Fix translation validation and current Home Assistant test compatibility - #71

Open
hmmbob wants to merge 2 commits into
dala318:mainfrom
hmmbob:fix/poollab-validation
Open

hmmbob wants to merge 2 commits into
dala318:mainfrom
hmmbob:fix/poollab-validation

Conversation

@hmmbob

@hmmbob hmmbob commented Oct 12, 2026 •

Copy link
Copy Markdown
Contributor

Hassfest rejects the literal LabCom URLs in the user and reconfigure descriptions. Replace both URLs with a description placeholder supplied by the config flow, preserving the displayed link.

The coordinator test also constructs an unused ConfigEntry at import time, which prevents collection on current Home Assistant because its constructor now requires subentries_data. Remove that unused object, assert coordinator initialization, and test that both configuration forms render their API-key link. Add Python 3.14 alongside 3.12 and run Python checks for translation, test-requirement and workflow changes.

Validation:

  • Full suite passes on Home Assistant 2026.10.1 / Python 3.14 (3 tests).
  • Hassfest passes using the same image digest as the failing check.
  • git diff --check passes.

This is separate from the API error-message change in #70.

The coordinator initialization test checks API identity and name. Polling policy is covered by #73, so this PR works with either the existing or updated interval.

schford added a commit to schford/python_poollab that referenced this pull request Oct 22, 2026
@hmmbob

hmmbob commented Oct 23, 2026

Copy link
Copy Markdown
Contributor Author

@dala318 You still maintaining this?

@dala318

dala318 commented Oct 24, 2026 via email

Copy link
Copy Markdown
Owner

@hmmbob

hmmbob commented Oct 24, 2026

Copy link
Copy Markdown
Contributor Author

I am, sort of at least. But right now I've been locked out from my github account due to som 2fa loop. I'm working on getting back in.

Ow, good luck with that....

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants