Skip to content

fix(ruff): fix mutable class attribute annotation - #68

Merged
pgiraud merged 1 commit into
mainfrom
marion_fix_ruff_table_args_annotation
Sep 11, 2026
Merged

pgiraud merged 1 commit into
mainfrom
marion_fix_ruff_table_args_annotation

Conversation

@MarionGiusti

Copy link
Copy Markdown
Collaborator

No description provided.

@pgiraud

pgiraud commented Sep 8, 2026

Copy link
Copy Markdown
Member

Oh. I didn't catch that error.

Can you please add "follow-up for commit xxxxx" (with the right commit number) to your commit message? Since it fixes a recent change.

Can you also please try to understand why this wasn't caught by various checks in CI? And if possible add / modify checks so that this kind of error gets detected.

@MarionGiusti
MarionGiusti force-pushed the marion_fix_ruff_table_args_annotation branch 2 times, most recently from 75c7795 to d7f140b Compare September 8, 2026 12:09
@MarionGiusti

Copy link
Copy Markdown
Collaborator Author

I'm not sure whether this is the right way to ignore the two mypy errors.

@MarionGiusti
MarionGiusti force-pushed the marion_fix_ruff_table_args_annotation branch from d7f140b to 2e6be12 Compare September 8, 2026 12:15
@pgiraud

pgiraud commented Sep 9, 2026

Copy link
Copy Markdown
Member

Adding mypy dependency to the project doesn't seem a good idea for now. If we want to do so, we need to add more type hints. In other words handle typing correctly instead of ignoring errors here and there.

By the way, I'm surprised mypy doesn't complain about missing type annotations.

Can you please remove the mypy related commit?

@pgiraud

pgiraud commented Sep 9, 2026

Copy link
Copy Markdown
Member

Actually, Mypy doesn't complain much because strict mode is not activated.

@MarionGiusti
MarionGiusti force-pushed the marion_fix_ruff_table_args_annotation branch from 2e6be12 to b93f1b5 Compare September 10, 2026 07:41
@MarionGiusti

Copy link
Copy Markdown
Collaborator Author

I removed the last commit and I don't understand why CI passed now without mypy ..

@pgiraud
pgiraud merged commit 8229af6 into main Sep 11, 2026
2 checks passed
@pgiraud
pgiraud deleted the marion_fix_ruff_table_args_annotation branch September 11, 2026 13:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants