fix(ruff): fix mutable class attribute annotation - #68
Conversation
|
Oh. I didn't catch that error. Can you please add "follow-up for commit xxxxx" (with the right commit number) to your commit message? Since it fixes a recent change. Can you also please try to understand why this wasn't caught by various checks in CI? And if possible add / modify checks so that this kind of error gets detected. |
follow up for commit 0827ad1.
75c7795 to
d7f140b
Compare
|
I'm not sure whether this is the right way to ignore the two mypy errors. |
d7f140b to
2e6be12
Compare
|
Adding mypy dependency to the project doesn't seem a good idea for now. If we want to do so, we need to add more type hints. In other words handle typing correctly instead of ignoring errors here and there. By the way, I'm surprised mypy doesn't complain about missing type annotations. Can you please remove the mypy related commit? |
|
Actually, Mypy doesn't complain much because |
2e6be12 to
b93f1b5
Compare
|
I removed the last commit and I don't understand why CI passed now without mypy .. |
No description provided.