Build format presets from the regional format - #168
Open
danielchalmers wants to merge 1 commit into
Open
danielchalmers wants to merge 1 commit into
danielchalmers wants to merge 1 commit into
Conversation
The clock presets and the default format were US patterns like {h:mm tt} and {MMM dd}, so in most regions "Time" showed a 12-hour time with no AM/PM (1:01 for 1:01 PM) and dates used US month-day order. They now come from the Windows regional format: 14:56 and "Di, 22. Sep" in Germany, 오후 2:56 in Korea, 9月22日 in China.
- US presets are unchanged except month-day uses d instead of dd, so "Sep 05" reads "Sep 5"
- "Time, 24-hour" only shows where the regional time is 12-hour, since elsewhere it repeats "Time"
- The default format for new installs follows the region; existing settings files keep their saved format
- The countdown target examples and the "Time" building block follow the region too
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The clock presets and the default format were US patterns like
{h:mm tt}and{MMM dd}. In most regions that meant "Time" showed a 12-hour time with no AM/PM (1:01for 1:01 PM) and dates used US month-day order. They now come from the Windows regional format, so Germany gets14:56andDi, 22. Sep, Korea gets오후 2:56, and China gets9月22日.dinstead ofdd, so "Sep 05" reads "Sep 5"