Repository navigation
Skip the restore point in the installer - #173
Merged
Merged
Conversation
- MSIFASTINSTALL=1: a double-click install can otherwise sit at "Please wait" while Windows creates a System Restore point, which protects nothing in a per-user app folder. - artifactErrorsFailBuild: a failed asset upload now fails the release job instead of leaving it green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Ports two fixes from Radial Actions (danielchalmers/RadialActions#87 and #91):
MSIFASTINSTALL=1inProduct.wxs. Windows Installer creates a System Restore point for installs that show a window, which can hold a double-click install at "Please wait while Windows configures DesktopClock" for most of a minute. It took 49 s in one Radial Actions run. The restore point protects nothing in a per-user%LocalAppData%folder.artifactErrorsFailBuild: trueindeploy.yml, so a failed asset upload turns the release job red instead of leaving a release with missing downloads.Validation
create-release-artifacts.MSIFASTINSTALL=1.wix msi validatereports only the ICE64 and ICE69 resultsmaster's package already has.master's design (5.5.0) to this one (5.5.1), with the clock running:DesktopClock.settingswas left, as before.No C# changed.