Skip to content

Skip the restore point in the installer - #173

Merged
danielchalmers merged 1 commit into
masterfrom
msi-fastinstall
Oct 6, 2026
Merged

danielchalmers merged 1 commit into
masterfrom
msi-fastinstall

Conversation

@danielchalmers

Copy link
Copy Markdown
Owner

Changes

Ports two fixes from Radial Actions (danielchalmers/RadialActions#87 and #91):

  • MSIFASTINSTALL=1 in Product.wxs. Windows Installer creates a System Restore point for installs that show a window, which can hold a double-click install at "Please wait while Windows configures DesktopClock" for most of a minute. It took 49 s in one Radial Actions run. The restore point protects nothing in a per-user %LocalAppData% folder.
  • artifactErrorsFailBuild: true in deploy.yml, so a failed asset upload turns the release job red instead of leaving a release with missing downloads.

Validation

  • Built the MSI locally with WiX 4.0.6 from a Release publish, using the commands in create-release-artifacts.
    • The decompiled package has MSIFASTINSTALL=1.
    • wix msi validate reports only the ICE64 and ICE69 results master's package already has.
  • Tested with an isolated test product that has its own UpgradeCode, component GUID, folders and registry key.
    1. master's design (5.5.0) to this one (5.5.1), with the clock running:
      • Restart Manager closed it;
      • the new package logged "SRSetRestorePoint skipped";
      • 5.5.1 started as the only copy.
      • The only restore point calls came from the old package removing itself, so the first upgrade away from 5.5.0 can still make one.
    2. This design to this design (5.5.1 to 5.5.2): no restore point calls at all, and 5.5.2 started as the only copy.
    3. Uninstall: the clock closed, and only DesktopClock.settings was left, as before.
  • The existing 5.2.0 install on the test machine was hash-checked before and after, and was unchanged.

No C# changed.

- MSIFASTINSTALL=1: a double-click install can otherwise sit at "Please wait" while Windows creates a System Restore point, which protects nothing in a per-user app folder.
- artifactErrorsFailBuild: a failed asset upload now fails the release job instead of leaving it green.
@github-actions github-actions Bot added the enhancement New feature or request label Oct 5, 2026
@danielchalmers
danielchalmers merged commit 4e23b7c into master Oct 6, 2026
5 checks passed
@danielchalmers
danielchalmers deleted the msi-fastinstall branch October 6, 2026 00:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant