Repository navigation
Improve the welcome and update notifications - #89
Merged
Merged
Conversation
- Selecting the update notification opens the latest release page, which its 'Select to see what's new' copy promised; it used to open Settings. - The update notification is silent like the startup ones, since it comes back on every launch until the update is installed. - While Run at Windows startup is off, the welcome says how to turn it on, since the hotkey otherwise stops working after the first restart.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Changes
TrayService.NotificationLinkfollows the existingNotificationActionpattern: the most recent notification's link, cleared by the next notification.UpdateService.LatestReleasePageUrl, shared with the Settings Download button.ForStartuptakesrunsAtStartup, and the hotkey-problem notification is unchanged.Validation
dotnet build: 0 warnings.dotnet test: 606 passed.TrayNotificationTextTestscover:ForStartuppassing the setting through.sound: false, like the startup notifications.Risks