Skip to content

Improve the welcome and update notifications - #89

Merged
danielchalmers merged 1 commit into
mainfrom
tray-notification-fixes
Oct 5, 2026
Merged

danielchalmers merged 1 commit into
mainfrom
tray-notification-fixes

Conversation

@danielchalmers

Copy link
Copy Markdown
Owner

Problem

  • Update notification click target. The update notification says "Select to see what's new", but selecting it opened Settings, not the release notes. This mismatch came in with Design and accessibility pass across all surfaces聽#86, which changed the copy.
  • Update notification sound. It plays a sound, and it comes back on every launch until the update is installed. The startup notifications are already silent.
  • Run at Windows startup. It's off by default and the first run never mentions it. A utility opened only by hotkey therefore stops working after the first restart, with nothing to say why.

Changes

  • Update notification.
    • Selecting it opens the latest release page. TrayService.NotificationLink follows the existing NotificationAction pattern: the most recent notification's link, cleared by the next notification.
    • It no longer plays a sound.
    • The release page URL moves to UpdateService.LatestReleasePageUrl, shared with the Settings Download button.
  • Welcome notification. While Run at Windows startup is off, it adds "To start Radial Actions when you sign in, select this and turn on Run at Windows startup." Selecting it already opens the General tab, which has that setting. ForStartup takes runsAtStartup, and the hotkey-problem notification is unchanged.

Validation

  • dotnet build: 0 warnings. dotnet test: 606 passed. TrayNotificationTextTests cover:
    • the welcome with Run at Windows startup on and off, with and without a hotkey;
    • ForStartup passing the setting through.
  • Ran a copy of the Debug build with a fresh settings file, without touching the installed app. To simulate a click, I posted the message the shell sends when a notification is selected (NIN_BALLOONUSERCLICK) to the tray icon's message window.
    • First run, update available (Debug reports 0.0.0). The welcome was accepted (its shown flag was saved). Selecting the latest notification opened "Release v0.7.0 路 danielchalmers/RadialActions" in the browser, and Settings stayed closed.
    • Welcome as the latest notification (update check off). Selecting it opened Settings on the General tab, and no browser page opened.
  • Not checked by eye or ear: how the notifications look on screen, and that the update notification is silent. The silence comes from passing sound: false, like the startup notifications.

Risks

  • Two notifications on first launch. If an update is available, the welcome and update notifications appear seconds apart. A shell click doesn't say which notification was selected, so selecting the welcome after the update notification has shown opens the release page. This was already true for action-failure notifications, which work the same way.

- Selecting the update notification opens the latest release page, which its 'Select to see what's new' copy promised; it used to open Settings.
- The update notification is silent like the startup ones, since it comes back on every launch until the update is installed.
- While Run at Windows startup is off, the welcome says how to turn it on, since the hotkey otherwise stops working after the first restart.
@danielchalmers
danielchalmers merged commit e1dbba4 into main Oct 5, 2026
1 check passed
@danielchalmers
danielchalmers deleted the tray-notification-fixes branch October 5, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant