Repository navigation
Clean up the installer and release workflow - #91
Merged
Merged
Conversation
- Show the app icon and project links in Installed apps. - Fix ICE03 (doubled backslashes in the registry key; Windows already wrote the same key) and ICE64 (remove the empty parent folder on uninstall). - Never harvest a settings file left in the publish folder, since an installer-owned settings file is deleted on upgrade. - Fail the release job when an asset upload fails instead of finishing green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
ARPPRODUCTICON) and links to the project and its issues. v0.7.0 shows a generic icon and no links.Package.wxshad doubled backslashes. Windows already normalized them toSoftware\Daniel Chalmers\RadialActions(checked on an existing install), so this writes the same key and only clears the validation error.%LocalAppData%\RadialActionsparent folder.RemoveFolderonly removes empty folders, so kept settings still keep it.Filesharvest excludes*.settings*. A localdotnet publishfolder used to run the app would otherwise putRadialActions.settingsinto the MSI, and an installer-owned settings file gets deleted on the next upgrade.artifactErrorsFailBuild: true, so a failed asset upload turns the release job red instead of leaving a release with missing downloads.Validation
dotnet build: 0 warnings.dotnet test: 607 passed.wix msi validate(with the expected per-user ICE38, ICE91 and ICE61 suppressed) passes, whilemain's package fails with ICE03 and ICE64;RadialActions.settingsin the publish folder,main's MSI includes it and this one doesn't.%AppData%\Microsoft\Installer\{ProductCode}\RadialActions.ico.Not included
The review also suggested saving settings in
OnSessionEnding, because a sign-out could end the process before WPF's queued shutdown saved an open Settings window. I simulated a sign-out three times onmain:WM_QUERYENDSESSIONandWM_ENDSESSIONto every window, then terminating the process. The edit was saved every time, so no change is needed.