Repository navigation
Skip restore point and drop wildcard RemoveFile from installer - #81
Merged
Merged
Conversation
…oad errors - MSIFASTINSTALL=1: a double-click install can otherwise sit at "Please wait" while Windows creates a System Restore point, which protects nothing in a per-user app folder. - Remove RemoveFile Name="*.*" On="both": every upgrade uninstalls the old version first, so it would delete anything the app keeps next to the exe. It deletes nothing today, but it's the line that deleted Radial Actions users' settings. - artifactErrorsFailBuild: a failed asset upload now fails the release job instead of leaving it green.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Ports three fixes from Radial Actions (danielchalmers/RadialActions#87 and #91):
MSIFASTINSTALL=1. Windows Installer creates a System Restore point for installs that show a window, which can hold a double-click install at "Please wait while Windows configures Sentry Deck" for most of a minute. It took 49 s in one Radial Actions run. The restore point protects nothing in a per-user%LocalAppData%folder.RemoveFile Name="*.*" On="both". Every upgrade uninstalls the old version first, so this row deletes anything sitting next to the exe on every upgrade and uninstall. It deletes nothing today, because Sentry Deck keeps no files there (logs go to%LocalAppData%\SentryDeck\logs, and FFmpeg goes in a subfolder the row doesn't recurse into). It's the same line that deleted Radial Actions users' settings, though, and it has no purpose: the default upgrade schedule already removes the old product's files.artifactErrorsFailBuild: trueindeploy.yml, so a failed asset upload turns the release job red instead of leaving a release with missing downloads.Validation
MSIFASTINSTALL=1and noRemoveFilerow.wix msi validatereports only the ICE03 and ICE64 errorsmain's package already has, so nothing new.main's design (1.1.0) to this one (1.1.1), with the app running:RemoveFilestill deleted the marker. That will happen once, on the upgrade away from 1.1.0, because the old package's rules apply when it removes itself.No C# changed, so the build, format and test steps aren't affected.