Repository navigation
Run the hermetic integration suite in CI - #46
Merged
Merged
Conversation
Planned-By: codex
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Task
DANI-10286 — Run the hermetic integration suite in CI
Description
At current main9c0ad8e91f22e91055ac7fbcb0b47cbba161e630, .github/workflows/ci.yml runs go test ./... and go test -race ./internal/... but no integration build tag. Makefile test-integration discovers and executes go test -tags=integration ./test/integration; it is explicitly hermetic and needs no Hadoop/Hive installation. DANI-10280's worker could not complete this target within its governed command timeout and deferred to CI, but main CI34007028578 success does not include that suite. Add the documented hermetic integration target to normal PR/main CI and establish actual execution. This is a coverage gap, not a claimed failing integration test. All-status search hermetic integration CI found no covering task. Preserve removed Docker runtime checks: this suite must remain host-native and hermetic.
Acceptance Criteria
Execution Summary
Click to expand
Outcome: success
Changes:
Hermetic integration teststep to.github/workflows/ci.ymlthat invokes the existingmake test-integrationtarget for both pull_request and main push events.Validation:
make test-integration: passed in 32.150s; discovered and executed 7 named tests: TestHermeticLifecycleAndWrappers, TestStatusAndStopUseRuntimeStateWhenStartupConfigDisappears, TestEnvExecAndWrapperPreserveChildExitCodesAndStreams, TestNativeValidationAndLaunchErrorsRemainReadable, TestDownstreamStartupFailureStopsDispatch, TestHDFSReadinessTimeoutUsesActiveOverlay, and TestStalePIDOwnershipMismatchDoesNotKillUnrelatedProcess. Go reported PASS for the integration package.go run github.com/rhysd/actionlint/cmd/actionlint@v1.7.12 .github/workflows/ci.yml .github/workflows/release.yml: passed with exit code 0 using a temporary module cache andGOSUMDB=off GOTOOLCHAIN=local; the default cache location was not writable in this runner.git diff --check: passed..github/workflows/ci.ymlis modified, with 3 insertions.Assessment: The normal PR/main CI path now executes the hermetic integration suite and fails closed on discovery or test failures through the existing Make target. The published candidate CI log remains pipeline-owned after this change is delivered.
Validation
Branch Freshness
origin/mainorbit/DANI-10286-6a9cd414