Repository navigation
Fix sample build definition and build instructions - #51
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
A normal CMake build with
CREATE_SAMPLE_PROJECT=ON(the default) fails while compilingcpp_example.cpp:gcransac::utils::loadMatrixis not declared at its four call sites. In the pinned graph-cut-ransacutils.h, that sample utility is guarded by the C++ preprocessor symbolCREATE_SAMPLE_PROJECT. The CMake option alone does not define it for the compiler.The build guides also omit changing into the cloned repository (and the README omits creating
build), whileBUILD.mddoes not initialize the required submodules. The README's CMake 2.8.12 requirement predates the pinned pybind11, whose CMakeLists requires 3.15.Change
CREATE_SAMPLE_PROJECTprivately forSampleProject, only in the existing enabled-sample branch.No estimator, dependency revision, public API or library compile definition changes.
Validation
Ubuntu 24.04, GCC 13.3, OpenCV 4.6, Eigen 3.4, gflags 2.2.2 and Python 3.12:
loadMatrixdeclarations.cmake -S . -B build -DCREATE_SAMPLE_PROJECT=ONandcmake --build build -j2succeeded, includingSampleProjectand the Python module.SampleProject --helpprinted its flags without running datasets/GUI.python -m pip install --no-build-isolation .in an isolated environment with the declared build tools installed.git diff --checkpassed.Windows/macOS builds, minimum-CMake execution, CMake GUI, full wheel CI and the bundled-data pytest suite were not run; no real images/dataset benchmarks were used.