Skip to content
This repository was archived by the owner on Mar 30, 2021. It is now read-only.

DAOS-1864 build: Components added: mchecksum and isa-l_crypt #26

Merged
jolivier23 merged 4 commits into from
Aug 6, 2019
Merged

DAOS-1864 build: Components added: mchecksum and isa-l_crypt #26

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
508f6b6
DAOS-1864 build: Components added: mchecksum and isa-l_crypt
ryon-jensen Jul 15, 2019
7284451
review feedback
ryon-jensen Jul 25, 2019
7da55b7
Merge branch 'master' of https://github.com/daos-stack/scons_local in…
ryon-jensen Jul 26, 2019
cf41af5
feedback
ryon-jensen Jul 26, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
28 changes: 8 additions & 20 deletions components/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,23 +112,6 @@ def define_mercury(reqs):
'make install'], libs=['opa'],
package='openpa-devel' if inst(reqs, 'openpa') else None)

if ARM_PLATFORM:

@jolivier23 jolivier23 Jul 29, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this no longer needed @vvenkates27 ?

@ryon-jensen ryon-jensen Aug 1, 2019

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm including mchecksum on the DAOS side for a checksum timing util. I didn't think it was needed elsewhere, but I guess I'm not 100% sure. @vvenkates27 ??

@vvenkates27 vvenkates27 Aug 3, 2019

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mchecksum is not needed for ARM anymore as ISA-L started supporting ARM. I actually had a patch locally to remove the requirement for using mchecksum in the checksum library for ARM . So I think we can ignore my patch #22, as this patch seems to do the same as well.

url = "https://github.com/mercury-hpc/mchecksum.git"
retriever = GitRepoRetriever(url)
reqs.define('mchecksum',
retriever=retriever,
commands=['cmake -DBUILD_SHARED_LIBS=ON $MCHECKSUM_SRC'
'-DBUILD_TESTING=ON '
'-DCMAKE_INSTALL_PREFIX=$MCHECKSUM_PREFIX '
'-DMCHECKSUM_ENABLE_COVERAGE=OFF '
'-DMCHECKSUM_ENABLE_VERBOSE_ERROR=ON '
'-DMCHECKSUM_USE_ZLIB=OFF '
'-DCMAKE_INSTALL_RPATH=$MCHECKSUM_PREFIX/lib '
'-DCMAKE_INSTALL_RPATH_USE_LINK_PATH=TRUE ',
'make $JOBS_OPT', 'make install'],
libs=['mchecksum'],
out_of_src_build=True)


def define_common(reqs):
"""common system component definitions"""
Expand Down Expand Up @@ -230,8 +213,6 @@ def define_pmix(reqs):
package='ompi-devel' if inst(reqs, 'ompi') else None)




def define_components(reqs):
"""Define all of the components"""
define_common(reqs)
Expand All @@ -245,8 +226,15 @@ def define_components(reqs):
retriever=GitRepoRetriever(
'https://github.com/01org/isa-l.git'),
commands=isal_build,
required_progs=['nasm', 'yasm'],
libs=["isal"])
reqs.define('isal_crypto',
retriever=GitRepoRetriever("https://github.com/intel/"
"isa-l_crypto"),
commands=['./autogen.sh ',
'./configure --prefix=$ISAL_CRYPTO_PREFIX '
'--libdir=$ISAL_CRYPTO_PREFIX/lib',
'make $JOBS_OPT', 'make install'],
libs=['isal_crypto'])


retriever = GitRepoRetriever("https://github.com/pmem/pmdk.git")
Expand Down