Skip to content

where clause should allow for "blockNumber" property #554

Description

@jellegerbrandy

The graph supports s block argument https://thegraph.com/docs/graphql-api#queries that we can use to get the state of the blockchain at a specific block.

this can be supported easily by adding a few lines for options.block in

export function createGraphQlQuery(options: ICommonQueryOptions, where: string = '') {

We need this for common, where we are using the 2.0.0-experimental build

While we are doing this, it would also be a good idea to have a more restrictive type on createGraphQLQuery() that limits the kind of argument you can pass - we did not catch this at first in our code because we could add the block argument without any type error or runtime error (it just skips the argument silently)

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions