Automate Sentry mTLS Initialization and uninstall logic#1663
Open
ayushsarode wants to merge 2 commits into
Open
Automate Sentry mTLS Initialization and uninstall logic#1663ayushsarode wants to merge 2 commits into
ayushsarode wants to merge 2 commits into
Conversation
Signed-off-by: ayushsarode <ayushsarode777@gmail.com>
Signed-off-by: ayushsarode <ayushsarode777@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a --enable-mtls flag to dapr init for self-hosted mode.
Previously, setting up mTLS locally required manually starting Sentry and configuring certificates. This PR automates the entire process so that running
dapr init --enable-mtlswill:Automatically generate the required certificates.
Start the
dapr_sentryDocker container alongside other Dapr services.Configure
dapr runto use mTLS by default.Ensure
dapr uninstallproperly cleans up the Sentry container.Issue reference
We strive to have all PR being opened based on an issue, where the problem or feature have been discussed prior to implementation.
Please reference the issue this PR will close: #1648
Checklist
Please make sure you've completed the relevant tasks for this PR, out of the following list: