Implement and use OpenCL buffer and image fill functions#21155
Open
jenshannoschwalm wants to merge 1 commit into
Open
Implement and use OpenCL buffer and image fill functions#21155jenshannoschwalm wants to merge 1 commit into
jenshannoschwalm wants to merge 1 commit into
Conversation
jenshannoschwalm
added
scope: image processing
jenshannoschwalm
force-pushed
the
buff_and_image_fills
branch
from
e632959 to
4c4ad9e
Compare
jenshannoschwalm
force-pushed
the
buff_and_image_fills
branch
from
4c4ad9e to
98ac0a5
Compare
jenshannoschwalm
force-pushed
the
buff_and_image_fills
branch
2 times, most recently
from
e47e60e to
3d9e5df
Compare
jenshannoschwalm
force-pushed
the
buff_and_image_fills
branch
3 times, most recently
from
7290383 to
cd94cb9
Compare
Collaborator
Author
|
Integration testsuite ok |
jenshannoschwalm
force-pushed
the
buff_and_image_fills
branch
from
cd94cb9 to
1f7cbaf
Compare
OpenCL 1.2 offers clEnqueueFillBuffer(), clEnqueueFillImage() and clEnqueueMigrateMemObjects(), they now are linked and made available as - dt_clEnqueueFillBuffer - dt_clEnqueueFillImage - dt_clEnqueueMigrateMemObjects Having the fill functions instead of specific kernels - simplifies code - results in some small perf gains as both are faster than the specific kernels.
jenshannoschwalm
force-pushed
the
buff_and_image_fills
branch
from
1f7cbaf to
2f2bb84
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
OpenCL 1.2 offers
clEnqueueFillBuffer()andclEnqueueFillImage(), they now are linked and made available asdt_clEnqueueFillBuffer()dt_clEnqueueFillImage()Having them instead of specific kernels
No diffs/regressions in integration tests. Both functions are 100% equivalen for the callers.