RFC: Ensure greyed darkroom loading screen#21402
Open
jenshannoschwalm wants to merge 1 commit into
Open
Conversation
We currently have the `darkroom/ui/loading_screen` conf option allowing users to choose if they want the grey background screen or not. Unfortunately switching this to "off" has some unwanted side effects, as reference see darktable-org#21128 and darktable-org#21395 For me the "loading_screen=off" behavior - has no relevance - adds code maintenance burden and fiddling with gtk - adds one preferences entry My proposal would simply be to remove this option.
Member
|
Agreed, less maintenance is good. |
Collaborator
|
I've had |
Collaborator
Author
|
So how to proceed on this - maybe just a safe "always enforce loading screen" on windows systems for 5.6.1? For later - i am not sure . Maybe using cairo_get_target() this way is problematic, we don't test for a nil-surface ... |
Contributor
|
Yeah, let's get rid of it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We currently have the
darkroom/ui/loading_screenconf option allowing users to choose if they want the grey background screen or not.Unfortunately switching this to "off" has some unwanted side effects, as reference see #21128 and #21395
For me the "loading_screen=off" behavior
My proposal would simply be to remove this option.
Maybe also for 5.6.1 ?