global: serialize package mutations - #4861
Open
aikins01 wants to merge 2 commits into
Open
Conversation
Use one canonical sibling lock so cache deletion cannot replace the locked inode. Keep repair helpers non-locking to avoid nested acquisition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Concurrent pub processes can currently interleave activation, deactivation, repair, and stale-snapshot recompilation while updating global package state and binstubs.
This serializes those mutations with one lock beside the canonical pub cache. The lock covers Git package-name discovery, each activation source, deactivation, the global-package phase of cache repair, and snapshot recompilation together with binstub refresh. Repair uses private non-locking helpers to avoid reacquiring the lock.
The cache parent must be writable so deleting or replacing the cache cannot replace the locked inode. Readers, older pub clients, direct filesystem writers, and cache clean remain outside this coordination.
Depends on #4860 and should merge after it.