Skip to content

Move to Safari drive to try to make safari testing less flaky - #2598

Merged
auto-submit[bot] merged 12 commits into
masterfrom
safari_sily
Sep 5, 2026
Merged

Move to Safari drive to try to make safari testing less flaky#2598
auto-submit[bot] merged 12 commits into
masterfrom
safari_sily

Conversation

@kevmoo

@kevmoo kevmoo commented Feb 23, 2026

Copy link
Copy Markdown
Member

No description provided.

@github-actions

github-actions Bot commented Feb 23, 2026

Copy link
Copy Markdown

PR Health

Changelog Entry ✔️
Package Changed Files

Changes to files need to be accounted for in their respective changelogs.

This check can be disabled by tagging the PR with skip-changelog-check.

@kevmoo
kevmoo marked this pull request as ready for review February 24, 2026 20:07
@kevmoo
kevmoo requested a review from a team as a code owner February 24, 2026 20:07
@kevmoo

kevmoo commented Feb 24, 2026

Copy link
Copy Markdown
Member Author

@natebosch – I fixed some things up and added a changelog entry

Comment thread pkgs/test/lib/src/runner/browser/default_settings.dart
Comment thread pkgs/test/lib/src/runner/browser/safari.dart Outdated
Comment thread pkgs/test/lib/src/runner/browser/safari.dart Outdated
@kevmoo

kevmoo commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

Rebased on latest master and addressed feedback:

  • Replaced stderr.writeln calls with structured ApplicationException throwing on startup/session errors.
  • Updated _safariDriverInstructions to remove obsolete defaults write commands and direct users to safaridriver --enable or Safari Settings.
  • Kept runtime identifier as safari to prevent breaking existing platform configurations.
  • Updated pkgs/test/README.md and moved changelog entry under ## 1.32.0-wip.
  • Validated live on macOS with all Safari tests passing.

@kevmoo

kevmoo commented Aug 26, 2026

Copy link
Copy Markdown
Member Author

@natebosch we can look at this again!

@kevmoo
kevmoo dismissed natebosch’s stale review August 26, 2026 23:30

All addressed!

@auto-submit
auto-submit Bot merged commit d983b56 into master Sep 5, 2026
82 checks passed
@auto-submit
auto-submit Bot deleted the safari_sily branch September 5, 2026 01:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants