Adding support for Build Daemon + Frontend Server with expression eval. - #2836
Open
Markzipan wants to merge 97 commits into
Open
Adding support for Build Daemon + Frontend Server with expression eval.#2836Markzipan wants to merge 97 commits into
Markzipan wants to merge 97 commits into
Conversation
1 task
Markzipan
force-pushed
the
expression_eval_dwds
branch
from
June 16, 2026 08:43
b86e719 to
79b7fa2
Compare
1 task
nshahan
reviewed
Jul 29, 2026
nshahan
reviewed
Jul 31, 2026
nshahan
left a comment
Contributor
There was a problem hiding this comment.
I know you are doing some manual testing, but are those at a point that you can link some CLs/PRs so we can track? I want to avoid landing this too early if we still have work to do before rolling into the Dart SDK, Flutter, and google3.
srujzs
reviewed
Jul 31, 2026
srujzs
left a comment
Contributor
There was a problem hiding this comment.
Most of my comments are centered around some of the classes we're adding here.
Contributor
Author
|
@nshahan I've added my Flutter PR + internal CL to the description; they should be up to date with this change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes at a glance
DWDS
asset_scheme.dart: AddedAssetSchemeto handle platform-specific file extensions (e.g.,.ddc.jsvs.dart.lib.js,.ddc.dillvs.dart.lib.dill) withBuildRunnerAssetSchemeandFrontendServerAssetSchemedefault impls.asset_reader.dart: RemovedPackageUriMapperin favor ofPathResolverinterface with default impls:FrontendServerPathResolver,BuildRunnerPathResolver, andFlutterPathResolver.web_path_translator.dartto hold asset translation rules (lib/segments, asset-scheme-specific renaming, etc.).loader.dart: AddedMetadataLoader(with default implMergedMetadataLoader) to allow platform-specific reading/parsing of metadata files.strategy.dart:LoadStrategynow requires anAssetSchemeand accepts aMetadataLoader.BuildSettingsnow acceptsuseDebuggerModuleNames.dwds.dart: Now exports:AssetScheme,MetadataLoader, and related impls.frontend_server_strategy_provider.dart: AddedFrontendServerBuildDaemonStrategyProviderto support Frontend Server + Build Daemon config with hot reload.daemon_expression_compiler.dart: AddedDaemonExpressionCompilerto forward expression evaluation requests directly to the instantiated Frontend Server worker via socket.location.dart: Updated sourcemap parsing to account for FES-specific URIs.Webdev and Serving
dev_workflow.dart: Spawns a backgroundbuild_frontend_server:fes_managersubprocess whenwebHotReloadis enabled. This creates a persistent shared Frontend Server (with a persistent scratch space) that can receive expression eval, hot reload, and hot restart requests while communicating with the build daemon.webdev_server.dart: UsesFrontendServerBuildDaemonStrategyProviderwhenwebHotReloadis enabled. Writesfes_manager_configto signal to build runner that a shared FES should be used. Now passesPathResolverandBuildSettings.app_domain.dart: Now supports hot reload requests (instead of rejecting them).server_manager.dart: PassesBuildDaemonClienttoWebDevServerfor build results to be accessible.Tests
context.dart: Test fixtures now specify aPathResolver. Rewrote_createBuildRunnerDdcLibraryBundleAssetHandlerto serve compiled outputs directly from the build cache or scratch space..ddc_merged_metadatavia thefes_manager.BuildStatus.succeededmessage early to avoid blocking downstream completers and locking.reloaded_sources.json. This is unlike a real app but works well for the test fixtures.build_web_compilersto4.8.7in test fixtures.Test Validation