chore: upgrade evo-sdk to 4.0.0-rc.1 and fix example-app CI#95
Merged
Conversation
Bump @dashevo/evo-sdk to 4.0.0-rc.1 across the root tutorials and example apps, and bump the project version to 4.0-rc. Extract PLATFORM_VERSION_OVERRIDE into a shared platformVersion.mjs module so the dashnote createNote example apps can pin the protocol version when calling document.toJSON. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
The dashmint-lab, dashnote, and dashnote-starter lockfiles had an inconsistent dependency graph: the top-level @emnapi/wasi-threads was pinned at 1.2.2 while the copy nested under @rolldown/binding-wasm32-wasi still required 1.2.1. These are optional wasm32-wasi deps that aren't installed on CI's linux-x64, so a plain npm install left the stale graph in place, but npm ci validates the full lockfile and rejected it. Regenerate each lockfile so the graph resolves consistently and npm ci passes. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Pull in the latest in-range transitive dev dependencies (rolldown 1.0.0-rc.15 to 1.0.3, vitest 4.1.5 to 4.1.8, eslint 8.58.2 to 8.61.0, and related type packages). No package.json changes; @dashevo/evo-sdk is unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (3)
✅ Files skipped from review due to trivial changes (1)
🚧 Files skipped from review as they are similar to previous changes (1)
📝 WalkthroughWalkthroughThis PR upgrades the example applications and core infrastructure to SDK 4.0.0-rc.1 while centralizing platform version management. The changes extract ChangesSDK 4.0.0-rc.1 Upgrade and Platform Version Management
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Poem
🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@setupDashClient-core.d.mts`:
- Line 156: Replace the sdk parameter type currently declared as unknown in
setupDashClient-core.d.mts for IdentityKeyManager.create,
IdentityKeyManager.createForNewIdentity, and AddressKeyManager.create with a
concrete type (EvoSDK or a minimal structural interface) that includes the
methods accessed by the implementation—specifically
identities.byPublicKeyHash(...), identities.fetch(...), and addresses.get(...);
update the type declaration so callers and editors see the correct contract
rather than an opaque unknown while leaving PLATFORM_VERSION_OVERRIDE: number
unchanged.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Pro
Run ID: cb328a6b-229f-4fb4-a2f1-c0d11cc589fb
⛔ Files ignored due to path filters (5)
example-apps/dashmint-lab/package-lock.jsonis excluded by!**/package-lock.jsonexample-apps/dashnote-starter/package-lock.jsonis excluded by!**/package-lock.jsonexample-apps/dashnote/package-lock.jsonis excluded by!**/package-lock.jsonexample-apps/dashproof-lab/package-lock.jsonis excluded by!**/package-lock.jsonpackage-lock.jsonis excluded by!**/package-lock.json
📒 Files selected for processing (12)
.github/workflows/deploy-example-apps.ymlexample-apps/dashmint-lab/package.jsonexample-apps/dashnote-starter/package.jsonexample-apps/dashnote-starter/src/dash/createNote.tsexample-apps/dashnote/package.jsonexample-apps/dashnote/src/dash/createNote.tsexample-apps/dashproof-lab/package.jsonpackage.jsonplatformVersion.d.mtsplatformVersion.mjssetupDashClient-core.d.mtssetupDashClient-core.mjs
Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Upgrades
@dashevo/evo-sdkto4.0.0-rc.1across the root tutorials and all four example apps, and repairs the GitHub Pages CI that builds the example apps.SDK upgrade
@dashevo/evo-sdkto4.0.0-rc.1in the root and in dashmint-lab, dashnote, dashnote-starter, and dashproof-lab; project version →4.0-rc.PLATFORM_VERSION_OVERRIDEinto a sharedplatformVersion.mjsmodule, consumed by the dashnotecreateNote.tsapps (passed todocument.toJSON) and re-exported fromsetupDashClient-core.mjs.CI fixes
@emnapi/wasi-threadsgraph was internally inconsistent (top-level1.2.2vs nested1.0.0-rc.15-era1.2.1). These are optionalwasm32-wasideps not installed on CI's linux-x64, sonpm installleft the stale graph in place whilenpm cirejected it. All four apps now passnpm ci.Notes
PLATFORM_VERSION_OVERRIDEis a temporary pin (see the TODO referencing dashpay/platform#3809) and should be removed once the protocol-version auto-detection fix lands in a consumed SDK release.Summary by CodeRabbit
PLATFORM_VERSION_OVERRIDEto support pinned platform version behavior.@dashevo/evo-sdk4.0.0-rc.1and bumped the package version to4.0-rc.setupDashClient-core.