Repository navigation
dev/issues-10 - #205
Open
luk384090-cloud wants to merge 5 commits into
Open
dev/issues-10#205luk384090-cloud wants to merge 5 commits into
luk384090-cloud wants to merge 5 commits into
Conversation
added 5 commits
October 10, 2026 18:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR contains two changes:
1. Refactor Assistants API imports to lazy loading (Fixes #207)
The
dashscope.assistants/dashscope.threadsmodules have been marked as deprecated, but previously a plainimport dashscopewould unconditionally import these modules, causing all users to seeDeprecationWarningeven if they never used the Assistants API.Changes: Removed static imports of these modules from
__init__.pyand switched to PEP 562__getattr__mechanism for on-demand loading. Import and deprecation warnings are only triggered when names likedashscope.Messages,dashscope.Runsare actually accessed._DEPRECATED_LAZY_IMPORTSmapping table and__getattr__/__dir__implementationtest_import_deprecation.pyunit tests to cover lazy loading behavior2. Fix Encryption using global api_key
The
Encryptionclass previously hardcodeddashscope.base_http_api_urlanddashscope.api_keyglobal variables, causingbase_url/api_keypassed as function parameters to be ignored in encryption scenarios.Changes: Added optional
base_urlandapi_keyparameters toEncryption.__init__, andapi_request_factorynow passes the current call's credentials when creating instances.