Skip to content

[1/7] Isolate legacy prepared statement batch execution - #1620

Merged
sreekanth-db merged 2 commits into
mainfrom
sreekanth-vadigi_data/stack/native-batch-legacy-seam
Aug 19, 2026
Merged

[1/7] Isolate legacy prepared statement batch execution#1620
sreekanth-db merged 2 commits into
mainfrom
sreekanth-vadigi_data/stack/native-batch-legacy-seam

Conversation

@sreekanth-db

@sreekanth-db sreekanth-db commented Aug 10, 2026

Copy link
Copy Markdown
Collaborator

🥞 Stacked PR

Use this link to review incremental changes.


Description

Extract the existing PreparedStatement batch implementation into a dedicated legacy executor.

This preserves current rewrite, interpolation, chunking, fallback, and error behavior while leaving PreparedStatementBatchExecutor as the coordination layer for future native batching.

Testing

  • Focused batch regression suites: 85 passed
  • Full jdbc-core suite: 3,602 passed, 88 skipped
  • Live serverless warehouse validation:
    • Individual parameter-set execution
    • Parameterized multi-row rewrite
    • Interpolated multi-row rewrite with chunking
    • Verified update counts and inserted rows

Additional Notes to the Reviewer

This is a behavior-preserving refactor. It does not add native batching, connection properties, or transport changes.

NO_CHANGELOG=true

Keep existing batching behavior behind a dedicated executor so native routing can be added without changing the compatibility fallback.

Signed-off-by: Sreekanth Vadigi <sreekanth.vadigi@databricks.com>

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@github-actions

Copy link
Copy Markdown

JDBC integration tests triggered (replay, thrift + sea). View workflow runs.

@github-actions

Copy link
Copy Markdown

Integration test approval reset.

New commits were pushed to this PR. Label(s) integration-test were removed for security.

A maintainer must re-review and re-add a label to preview tests again. (The real gate runs in the merge queue.)

Latest commit: e92de04

@github-actions

Copy link
Copy Markdown

JDBC integration tests triggered (replay, thrift + sea). View workflow runs.

@peco-review-bot peco-review-bot Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ No issues identified by the review bot.

@sreekanth-db
sreekanth-db added this pull request to the merge queue Aug 19, 2026
Merged via the queue into main with commit bc27aae Aug 19, 2026
28 of 29 checks passed
@sreekanth-db
sreekanth-db deleted the sreekanth-vadigi_data/stack/native-batch-legacy-seam branch August 19, 2026 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants