Add telemetry error classification guardrails - #1629
Merged
samikshya-db merged 3 commits intoAug 20, 2026
Merged
Conversation
Signed-off-by: Prathamesh Baviskar <prathamesh.baviskar@databricks.com>
prathamesh-db
force-pushed
the
codex/brickyard-m5-oss-guardrail
branch
from
August 18, 2026 05:59
73ae52f to
c5f5fa7
Compare
Signed-off-by: Prathamesh Baviskar <prathamesh.baviskar@databricks.com>
prathamesh-db
marked this pull request as ready for review
August 19, 2026 08:49
samikshya-db
approved these changes
Aug 19, 2026
samikshya-db
left a comment
Collaborator
There was a problem hiding this comment.
When you are raising a fix, see if this is useful - we can modify the claude.md as required. Approving this for now.
Contributor
Author
|
/merge |
Contributor
Author
|
/trigger all |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Telemetry-visible JDBC errors need two things to remain useful downstream: a stable
DatabricksDriverErrorCodeand an explicit driver/server/user classification. Missing either can leave the telemetry dashboard and automation taxonomy out of sync.This PR adds lightweight repository guardrails for future error changes:
CLAUDE.mdtells contributors to reuse or add an enum-backed code, verify the emitted name and numeric code in tests, and record the classification.The classification source is maintainer-owned and is not available to public-repository CI. The checks therefore remain review-based instead of adding CI that could validate only a PR checkbox, not the underlying classification.
NO_CHANGELOG=true
Testing
Documentation and review-routing changes only; this PR does not change driver build or runtime behavior.
git diff --checkpasses.Telemetry Errors
DatabricksDriverErrorCodewhere appropriate, and any new code is uniquely numbered and tested.Additional Notes to the Reviewer
This is intentionally a lightweight contributor and reviewer guardrail. It does not duplicate the maintainer-owned taxonomy in the public repository or automatically classify existing errors.