Skip to content

Add telemetry error classification guardrails - #1629

Merged
samikshya-db merged 3 commits into
databricks:mainfrom
prathamesh-db:codex/brickyard-m5-oss-guardrail
Aug 20, 2026
Merged

Add telemetry error classification guardrails#1629
samikshya-db merged 3 commits into
databricks:mainfrom
prathamesh-db:codex/brickyard-m5-oss-guardrail

Conversation

@prathamesh-db

@prathamesh-db prathamesh-db commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

Telemetry-visible JDBC errors need two things to remain useful downstream: a stable DatabricksDriverErrorCode and an explicit driver/server/user classification. Missing either can leave the telemetry dashboard and automation taxonomy out of sync.

This PR adds lightweight repository guardrails for future error changes:

  • CLAUDE.md tells contributors to reuse or add an enum-backed code, verify the emitted name and numeric code in tests, and record the classification.
  • The pull-request template asks authors to confirm those steps or request maintainer help when they cannot access the classification system.

The classification source is maintainer-owned and is not available to public-repository CI. The checks therefore remain review-based instead of adding CI that could validate only a PR checkbox, not the underlying classification.

NO_CHANGELOG=true

Testing

Documentation and review-routing changes only; this PR does not change driver build or runtime behavior.

  • Verified the exact error-code enum path referenced by the guidance.
  • Verified the pull-request checklist covers both error-code and classification updates.
  • git diff --check passes.

Telemetry Errors

  • Not applicable — this PR does not add or change a telemetry-visible error.
  • Applicable — the error uses DatabricksDriverErrorCode where appropriate, and any new code is uniquely numbered and tested.
  • Applicable — its driver/server/user classification is linked, or maintainer help is requested because the author cannot access the classification.

Additional Notes to the Reviewer

This is intentionally a lightweight contributor and reviewer guardrail. It does not duplicate the maintainer-owned taxonomy in the public repository or automatically classify existing errors.

Signed-off-by: Prathamesh Baviskar <prathamesh.baviskar@databricks.com>
@prathamesh-db
prathamesh-db force-pushed the codex/brickyard-m5-oss-guardrail branch from 73ae52f to c5f5fa7 Compare August 18, 2026 05:59
Signed-off-by: Prathamesh Baviskar <prathamesh.baviskar@databricks.com>
@prathamesh-db
prathamesh-db marked this pull request as ready for review August 19, 2026 08:49

@samikshya-db samikshya-db left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When you are raising a fix, see if this is useful - we can modify the claude.md as required. Approving this for now.

@prathamesh-db

Copy link
Copy Markdown
Contributor Author

/merge

@prathamesh-db

Copy link
Copy Markdown
Contributor Author

/trigger all

@samikshya-db
samikshya-db merged commit 29e5ab2 into databricks:main Aug 20, 2026
22 of 23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants