Skip to content

Add N9300 switch memory check#370

Open
Priyanka-Patil14 wants to merge 2 commits into
datacenter:v4.2.0-devfrom
Priyanka-Patil14:feature/n9300-switch-memory-check
Open

Add N9300 switch memory check#370
Priyanka-Patil14 wants to merge 2 commits into
datacenter:v4.2.0-devfrom
Priyanka-Patil14:feature/n9300-switch-memory-check

Conversation

@Priyanka-Patil14

@Priyanka-Patil14 Priyanka-Patil14 commented Mar 20, 2026

Copy link
Copy Markdown

Summary
-This PR adds a new validation check: N9K-C93180YC-FX3 Switch Memory Less Than 32GB.

-The check is version-independent and validates that N9K-C93180YC-FX3 switches have at least 32 GB memory. This is tracked under defect CSCwm42741.

What Changed

  • Added n9k_c93180yc_fx3_switch_memory_check in aci-preupgrade-validation-script.py
  • Added validation documentation in docs/docs/validations.md
  • Added dedicated unit tests and test data under:
    • tests/checks/n9k_c93180yc_fx3_switch_memory_check/

Check Behavior

  • Returns N/A if no N9K-C93180YC-FX3 switches are present
  • Returns FAIL_O for N9K-C93180YC-FX3 nodes with memory < 32 GB
  • Returns PASS when all N9K-C93180YC-FX3 nodes have >= 32 GB

Test Validation
Executed:
'pytest tests/checks/n9k_c93180yc_fx3_switch_memory_check/ -q'

Result:
5 passed in 0.08s

No failures observed.

@Harinadh-Saladi Harinadh-Saladi left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pls address the comments

Comment thread docs/docs/validations.md Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread tests/checks/n9300_switch_memory_24g_check/test_n9300_switch_memory_24g_check.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread docs/docs/validations.md Outdated
@asraf-khan

Copy link
Copy Markdown
Contributor

@Priyanka-Patil14 please attach test result from APIC for possible scenario's

@Priyanka-Patil14

Copy link
Copy Markdown
Author

Memory_Check_logs.docx

Uploaded the logs.

Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
@asraf-khan

Copy link
Copy Markdown
Contributor

@Priyanka-Patil14 can you please provide updated script output from APIC and error handling cases?

Comment thread aci-preupgrade-validation-script.py Outdated
@Priyanka-Patil14

Priyanka-Patil14 commented Mar 24, 2026

Copy link
Copy Markdown
Author

@Priyanka-Patil14 can you please provide updated script output from APIC and error handling cases?

MemoryCheck_Logs.txt
APIC_Output_Logs.txt

Uploaded the logs. Please review it.

Comment thread aci-preupgrade-validation-script.py
@Priyanka-Patil14 Priyanka-Patil14 changed the base branch from master to v4.1.0-dev April 9, 2026 10:44
Comment thread aci-preupgrade-validation-script.py Outdated

@kahande kahande left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved.

@Priyanka-Patil14

Copy link
Copy Markdown
Author

Attached pytest and full script run logs as requested.
FullRun_MemoryCheck_Logs.txt
MemoryCheck_32Gb_Pytest_logs.txt

Comment thread docs/docs/validations.md Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
@Priyanka-Patil14 Priyanka-Patil14 changed the base branch from v4.1.0-dev to v4.2.0-dev May 25, 2026 04:52
@Priyanka-Patil14 Priyanka-Patil14 force-pushed the feature/n9300-switch-memory-check branch 3 times, most recently from 8197e54 to d7d4289 Compare May 25, 2026 07:13
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread docs/docs/validations.md
Comment thread docs/docs/validations.md Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread aci-preupgrade-validation-script.py
@Priyanka-Patil14

Priyanka-Patil14 commented May 26, 2026

Copy link
Copy Markdown
Author

@lovkeshsharma702 lovkeshsharma702 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intigrated test completed with no fault.

Comment thread docs/docs/validations.md Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread docs/docs/validations.md Outdated
Comment thread aci-preupgrade-validation-script.py Outdated
Comment thread aci-preupgrade-validation-script.py Outdated

@lovkeshsharma702 lovkeshsharma702 left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

intigration test passed. Logic changed, Code added in bug section with bug reference.

@monrog2

monrog2 commented Jun 29, 2026

Copy link
Copy Markdown
Collaborator

Last SR attach did have issues after upgrade, would prefer that this FLAG a FAIL_O vs just a MANUAL. do not want to give a false sense of security when this can prevent switches from coming back post-upgrade depending on the target version.

@monrog2 monrog2 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

change MANUAL to FAL_O

@Priyanka-Patil14 Priyanka-Patil14 force-pushed the feature/n9300-switch-memory-check branch from 9830f7c to 6c7348b Compare June 29, 2026 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants