Feature/ci azure improvements #25
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| #! /bin/bash | ||
| set -e | ||
| cd "$DATACOVES__DBT_HOME" | ||
| git fetch --tags | ||
| date_version=$(date -u +%Y%m%d) | ||
| # Version scheme: YYYYMMDD.N.0, N = next unused sequence number for today. | ||
| last_sequence=$( | ||
| git tag --list "${date_version}.*" | | ||
| sed -E "s/^${date_version}\.([0-9]+)\..*/\1/" | | ||
| grep -E '^[0-9]+$' | sort -n | tail -1 | ||
| ) | ||
| if [ -z "$last_sequence" ]; then next_sequence=1; else next_sequence=$((last_sequence + 1)); fi | ||
| new_version="${date_version}.${next_sequence}.0" | ||
| # Anchored to line start so it only matches `version:`, not `config-version:`. | ||
| sed -i "s/^version:.*/version: '${new_version}'/g" dbt_project.yml | ||
| git add dbt_project.yml | ||
| # [skip ci] prevents this commit from retriggering push-to-main.yml. | ||
| git commit -m "Set deployment version to ${new_version} [skip ci]" | ||
| git tag -m "[skip ci]" "${new_version}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| #!/bin/bash | ||
| set -e | ||
|
|
||
|
Author
There was a problem hiding this comment. yes, I implemented the |
||
| SOURCE_BRANCH="${1#refs/heads/}" | ||
| TARGET_BRANCH="${2#refs/heads/}" | ||
|
|
||
| if [ "$SOURCE_BRANCH" = "$TARGET_BRANCH" ]; then | ||
| echo "Source and target branch are the same ($SOURCE_BRANCH); skipping branch validation." | ||
| exit 0 | ||
| fi | ||
|
|
||
| if [[ "$SOURCE_BRANCH" != feature/* && "$SOURCE_BRANCH" != infra/* ]]; then | ||
| echo "ERROR: Source branch '$SOURCE_BRANCH' must start with 'feature/' or 'infra/'." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [ "$TARGET_BRANCH" != "main" ] && ! [[ "$SOURCE_BRANCH" == feature/* && "$TARGET_BRANCH" == feature/* ]]; then | ||
| echo "ERROR: Target branch must be 'main', or, for a feature/ source branch, another feature/ branch. Got '$TARGET_BRANCH'." | ||
| exit 1 | ||
| fi | ||
|
|
||
| git fetch origin main | ||
| # Require the PR branch to already contain latest main (avoids deploying stale merges). | ||
| commits_behind=$(git rev-list --count HEAD..origin/main) | ||
| if [ "$commits_behind" -gt 0 ]; then | ||
| echo "ERROR: Branch '$SOURCE_BRANCH' is $commits_behind commit(s) behind 'main'. Please merge/pull main into your branch and push again." | ||
| exit 1 | ||
| fi | ||
|
|
||
| if [[ "$SOURCE_BRANCH" == infra/* ]]; then | ||
| changed_transform_files=$(git diff --name-only origin/main HEAD -- transform/) | ||
| if [ -n "$changed_transform_files" ]; then | ||
| echo "ERROR: infra/ branches cannot modify transform/. dbt model changes must use a feature/ branch." | ||
| echo "$changed_transform_files" | ||
| exit 1 | ||
| fi | ||
| fi | ||
|
|
||
| echo "Branch validation passed: '$SOURCE_BRANCH' -> '$TARGET_BRANCH'." | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I dont think we need both versions * and **
look at this and ask claude
https://github.com/datacoves/balboa/blob/main/.github/workflows/10_feature_dbt_checks.yml#L8
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It mirrors the existing
transform/*+transform/**/*style already in this file so the new paths matched the established convention. But you're right that it's redundant:automate/dbt/**already covers both direct and nested files, so I'll collapse it to a single line.